Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reinforced walls can be built ontop of window frames. #6436

Closed
cm13-issue-bot opened this issue Jun 11, 2024 · 0 comments · Fixed by #6837
Closed

Reinforced walls can be built ontop of window frames. #6436

cm13-issue-bot opened this issue Jun 11, 2024 · 0 comments · Fixed by #6837
Labels
Bug Admin events aren't bugs

Comments

@cm13-issue-bot
Copy link

Testmerges

#6071: '[V] Sorokyne Strata: fixes and changes .' by Venuska1117 at commit 77b1ffb107
#6304: 'STEEL DIVISON (Re-introduces 200 pop locked tank) [CODE BOUNTY]' by Red-byte3D at commit b51bd40abe
#6355: 'ID Mod computer biometrics' by realforest2001 at commit bd4cb15883
#6383: 'Replaces the ARC interior & ARC tweaks' by Zonespace27 at commit c9e49da969
#6363: 'First Drop Protections: Gas and Static Turrets' by Drulikar at commit bb9a7df8e2
#6388: 'gayons' by 567Turtle at commit 4f9151f1ba
#6334: 'Xenomorph Endgame' by Git-Nivrak at commit 3db8a9a0e2
#6039: 'Project ARES TM Holder (v5)' by realforest2001 at commit 9f4c76c456
#6392: 'Adds in-game bug reports without needing a GitHub account' by vero5123 at commit 292f4f0efe

Round ID

22601

Description of the bug

This overlays the window-frame over the wall, instead of just the wall.

What's the difference with what should have happened?

Should probably not be able to put girders on window frames.

How do we reproduce this bug?

  1. Build girder ontop of window frame.
  2. finish girder.
  3. have window overlay over wall.

Report details

Author: AnonHault
Admin: Piterskiy
@cm13-issue-bot cm13-issue-bot added the Bug Admin events aren't bugs label Jun 11, 2024
@VileBeggar VileBeggar mentioned this issue Jul 31, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Aug 1, 2024
@VileBeggar @Drulikar
Stops structures from being built on dense objects (#6837)
c11d28e 
# About the pull request

stops structures like girders, beds, chairs and tables from being able
to be built on top of dense objects (like tables and window frames)
fixes #6436

# Explain why it's good for the game


![stop
this](https://github.com/user-attachments/assets/a98e0d88-6f85-4e1c-acb4-d37251a6a3a6)

stops weird things like this from being able to be constructed.


# Testing Photographs and Procedure
<details>
<summary>Screenshots & Videos</summary>

i tested it very lightly with some generic constructions and it seems to
work fine


https://github.com/user-attachments/assets/76a790dd-4e2c-41b4-b11a-6193b13fb6cc


</details>


# Changelog
:cl:
fix: You can no longer build structures on top of dense objects. This
prevents weird layering happening with walls and tables, window frames,
etc.
/:cl:

---------

Co-authored-by: Drathek <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Admin events aren't bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Stops structures from being built on dense objects VileBeggar/cmss13
1 participant
@cm13-issue-bot