Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stops structures from being built on dense objects #6837

Merged

Conversation

VileBeggar
Copy link
Contributor

@VileBeggar VileBeggar commented Jul 31, 2024

About the pull request

stops structures like girders, beds, chairs and tables from being able to be built on top of dense objects (like tables and window frames)
fixes #6436

Explain why it's good for the game

stop this

stops weird things like this from being able to be constructed.

Testing Photographs and Procedure

Screenshots & Videos

i tested it very lightly with some generic constructions and it seems to work fine

Metal.Fix.mp4

Changelog

🆑
fix: You can no longer build structures on top of dense objects. This prevents weird layering happening with walls and tables, window frames, etc.
/:cl:

@github-actions github-actions bot added the Fix Fix one bug, make ten more label Jul 31, 2024
@Venuska1117
Copy link
Contributor

Venuska1117 commented Jul 31, 2024

can you include doors too? seeing wall after you destroy electrocuted doors always haunt me.

@Diegoflores31
Copy link
Contributor

This can be very problematic untill Girders are properly fixed to have a 0 health sprite. currently broken girders are invisible and have no sprite . this could cause issues if this PR is merged since you wont be allowed to build because of a invisible structure

@VileBeggar
Copy link
Contributor Author

can you include doors too? seeing wall after you destroy electrocuted doors always haunt me.

sure, no biggie. it's a bit scummy and doesn't make much sense either.

This can be very problematic untill Girders are properly fixed to have a 0 health sprite. currently broken girders are invisible and have no sprite . this could cause issues if this PR is merged since you wont be allowed to build because of a invisible structure

destroyed girders are not dense and therefore will not block construction. they will, however, allow building on top of them, and then welding them up to a girder again. that lets you make a wall on top of other stuff which is what this pr is supposed to fix. either way it's not a hard fix to make so i'll get it done, thanks for bringing it up

code/game/objects/items/frames/table_rack.dm Outdated Show resolved Hide resolved
@Drulikar Drulikar added this pull request to the merge queue Aug 1, 2024
Merged via the queue into cmss13-devs:master with commit c11d28e Aug 1, 2024
27 checks passed
@VileBeggar VileBeggar deleted the fix-reinforced-wall-windowframe branch August 1, 2024 20:33
cm13-github added a commit that referenced this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Fix one bug, make ten more
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reinforced walls can be built ontop of window frames.
4 participants