Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

synthesis simulator UI runtime #6644

Closed
cm13-issue-bot opened this issue Jul 7, 2024 · 0 comments · Fixed by #6568
Closed

synthesis simulator UI runtime #6644

cm13-issue-bot opened this issue Jul 7, 2024 · 0 comments · Fixed by #6568
Labels
Bug Admin events aren't bugs

Comments

@cm13-issue-bot
Copy link

Testmerges

#6334: 'Xenomorph Endgame' by Git-Nivrak at commit 18cfcab3cd
#6400: 'Adds Sunsets to Roundstart, adds Sunrises to Marine Victories, and Survs can hear Evo Announcement Screeches now' by GrrrKitten at commit 2927345720
#6308: 'Hostile Survivor Rework' by Steelpoint at commit bf51f9e551
#6039: 'Project ARES TM Holder (v5)' by realforest2001 at commit 370c1d53f8
#6248: 'New Map: LV-759 Hybrisa Prospera' by Zenith00000 at commit d874f97e11
#6594: 'Ports "Adds a Chat Reliability Layer"' by Git-Nivrak at commit 9b0717ad64
#6568: 'Chemical simulator TGUI' by kiVts at commit 5280d571c9

Round ID

22968

Description of the bug

Player ahelped about the simlulator not working after accessing it. The buttons indeed did not respond.

What's the difference with what should have happened?

Theoretically the simulator buttons should respond.

How do we reproduce this bug?

Access Simulator
Buttons stop working

Attached logs

[2024-07-07 08:55:19.642] runtime error: Cannot read null.name
 - proc name: ui data (/obj/structure/machinery/chem_simulator/ui_data)
 -   source file: code/modules/reagents/chemistry_machinery/chem_simulator.dm,127
 -   usr: null
 -   src: the synthesis simulator (/obj/structure/machinery/chem_simulator)
 -   src.loc: the floor (150,154,3) (/turf/open/floor/almayer)
 -   call stack:
 - the synthesis simulator (/obj/structure/machinery/chem_simulator): ui data(Bred Dahne (/mob/living/carbon/human))
 - /datum/tgui (/datum/tgui): get payload(null, 1, null)
 - /datum/tgui (/datum/tgui): send update(null, null)
 - tgui (/datum/controller/subsystem/tgui): try update ui(Bred Dahne (/mob/living/carbon/human), the synthesis simulator (/obj/structure/machinery/chem_simulator), /datum/tgui (/datum/tgui))
 - the synthesis simulator (/obj/structure/machinery/chem_simulator): tgui interact(Bred Dahne (/mob/living/carbon/human), /datum/tgui (/datum/tgui))
 - /datum/tgui (/datum/tgui): process(0.9, 0)
 - tgui (/datum/controller/subsystem/tgui): fire(0)
 - tgui (/datum/controller/subsystem/tgui): ignite(0)
 - Master (/datum/controller/master): RunQueue()
 - Master (/datum/controller/master): Loop(2)
 - Master (/datum/controller/master): StartProcessing(0)

Additional details

  • Author: SmellyHippie
  • Admin: SmellyHippie
  • Note: None
@cm13-issue-bot cm13-issue-bot added the Bug Admin events aren't bugs label Jul 7, 2024
github-merge-queue bot pushed a commit that referenced this issue Jul 11, 2024
# About the pull request

The one of last NanoUIs are nuked, chemical simulator was moved to tgui,
along with other changes needed to accomplish that.
Consider that the 1.5 part of research rework

Conflicting and combining properties are now in GLOB lists, one bugfix
in save_new_properties, it literally never worked, you cannot add
conflicting properties in create, relate in conflict, and etc etc

Its working and is 100% complete, ~~but I need to do some final
polish(grammer, looks, etc). but if you dont mind ugliness then its
working.~~ Done and looks pretty cool
resolves #6644 
# Explain why it's good for the game
Conflicting properties feature, less nanouis, more friendly to new
features.
# Testing Photographs and Procedure
<details>
<summary>Screenshots & Videos</summary>


![image](https://github.com/cmss13-devs/cmss13/assets/48099872/a1b06cf4-ae84-46b9-93af-69cd73acd3b6)

![image](https://github.com/cmss13-devs/cmss13/assets/48099872/5a3d81b7-903a-4a73-842e-2a212a9fc6b4)

</details>


# Changelog
:cl: Kivts
ui: The Company spent some money to upgrade the chemical simulator to
work on the TGUI, Including a few prepaid features.
/:cl:

---------

Co-authored-by: harryob <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Admin events aren't bugs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant