-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chemical simulator TGUI #6568
Merged
Merged
Chemical simulator TGUI #6568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cm13-github
added a commit
that referenced
this pull request
Jul 3, 2024
Closed
cm13-github
added a commit
that referenced
this pull request
Jul 4, 2024
Conflicts have been resolved. A maintainer will review the pull request shortly. |
cm13-github
removed
the
Merge Conflict
PR can't be merged because it touched too much code
label
Jul 7, 2024
cm13-github
added a commit
that referenced
this pull request
Jul 8, 2024
3 tasks
cm13-github
added a commit
that referenced
this pull request
Jul 10, 2024
harryob
reviewed
Jul 10, 2024
harryob
reviewed
Jul 10, 2024
harryob
reviewed
Jul 10, 2024
harryob
reviewed
Jul 10, 2024
cm13-github
added a commit
that referenced
this pull request
Jul 10, 2024
cm13-github
added a commit
that referenced
this pull request
Jul 10, 2024
Co-authored-by: harryob <[email protected]>
cm13-github
added a commit
that referenced
this pull request
Jul 11, 2024
cm13-github
added a commit
that referenced
this pull request
Jul 11, 2024
harryob
approved these changes
Jul 11, 2024
just wanna note. you cant relate research chem with other research chem. and basic chemicals+ medical chem. I'm testing it right now and its pain |
read the issue you created. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
The one of last NanoUIs are nuked, chemical simulator was moved to tgui, along with other changes needed to accomplish that.
Consider that the 1.5 part of research rework
Conflicting and combining properties are now in GLOB lists, one bugfix in save_new_properties, it literally never worked, you cannot add conflicting properties in create, relate in conflict, and etc etc
Its working and is 100% complete,
but I need to do some final polish(grammer, looks, etc). but if you dont mind ugliness then its working.Done and looks pretty coolresolves #6644
Explain why it's good for the game
Conflicting properties feature, less nanouis, more friendly to new features.
Testing Photographs and Procedure
Screenshots & Videos
Changelog
🆑 Kivts
ui: The Company spent some money to upgrade the chemical simulator to work on the TGUI, Including a few prepaid features.
/:cl: