Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shotgun Sentry Bug #7045

Closed
3 tasks done
BOBAMAx opened this issue Aug 26, 2024 · 4 comments · Fixed by #7471
Closed
3 tasks done

Shotgun Sentry Bug #7045

BOBAMAx opened this issue Aug 26, 2024 · 4 comments · Fixed by #7471
Labels
Bug Admin events aren't bugs Confirmed Bug We have the same at home!

Comments

@BOBAMAx
Copy link
Contributor

BOBAMAx commented Aug 26, 2024 •
edited
Loading

Testmerges

doesnt matter

Round ID

No response

Description of the bug

Desktop.2024.08.26.-.11.31.17.03.mp4

shotgun sentry bonus projectiles originate from the mob that placed it down instead of the shotgun sentry.

now tested on live thanks to the smellyhippie himself

This is actually pretty abusable if you know how it works because you can bait xenos into eating 130 damage of bonus projectile while not actually being in range of the sentry gun while resting/otherwise incapacitated.

What's the difference with what should have happened?

bonus projectiles should not be coming from the mob that placed the sentry but the sentry itself

How do we reproduce this bug?

put down a shotgun sentry and watch it do this

Issue Bingo
@BOBAMAx BOBAMAx added the Bug Admin events aren't bugs label Aug 26, 2024
@Doubleumc
Copy link
Contributor

Likely related to #6784

@ItsVyzo ItsVyzo added the Confirmed Bug We have the same at home! label Aug 26, 2024
@ItsVyzo ItsVyzo mentioned this issue Aug 27, 2024
Closed
3 tasks
@Ansekishokuu
Copy link
Contributor

Probably fixed with #7406, tested and it didn't happen to me.

@BOBAMAx
Copy link
Contributor Author

BOBAMAx commented Nov 2, 2024

@Drulikar @Ansekishokuu this is still an issue, just tested it on live

@Drulikar Drulikar reopened this Nov 2, 2024
@BOBAMAx
Copy link
Contributor Author

BOBAMAx commented Nov 2, 2024

https://www.youtube.com/watch?v=MhJTFaawDWg

@Drulikar Drulikar mentioned this issue Nov 2, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Nov 3, 2024
@Drulikar
Fix sentry additional shots and sentry flamer cause_data (#7471)
33e952c 
# About the pull request

This PR is a follow-up to #7406 correcting an issue where sentries
swapped the shooter and firer vars to fix #7045. It also corrects the
erroneous initialization for flamer sentries so now they will actually
attribute kills to the sentry and explain in the death message both the
sentry and owner.

# Explain why it's good for the game

Fixes additional projectiles being fired from humans that placed a
shotgun sentry; the shots are supposed to be from the sentry not
magically from the player somewhere else. Also improves the death
messages for flamer sentry kills and actually attributes kills to the
sentry.

# Testing Photographs and Procedure
<details>
<summary>Screenshots & Videos</summary>


![sentry](https://github.com/user-attachments/assets/aae7c676-216b-4c18-a7df-9781c5e83c26)

![image](https://github.com/user-attachments/assets/e7db396c-b36d-4ec8-b952-7f623a29b735)

</details>

# Changelog
:cl: Drathek
fix: Fixes additional projectiles being fired from humans that placed a
shotgun sentry instead of the sentry.
fix: Fixes cause_data for flamer sentries so now kills they make are
explained in the message and attributed to the kill counter for the
sentry.
/:cl:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Admin events aren't bugs Confirmed Bug We have the same at home!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix sentry additional shots and sentry flamer cause_data Drulikar/cmss13
6 participants
@Doubleumc @ItsVyzo @BOBAMAx @Drulikar @Ansekishokuu and others