Fix sentry additional shots and sentry flamer cause_data #7471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drulikar
added
the
Testmerge Candidate
cm13-github
added a commit
that referenced
this pull request
Nov 2, 2024
harryob
approved these changes
Nov 2, 2024
cm13-github
added a commit
that referenced
this pull request
Nov 2, 2024
3 tasks
This was referenced Nov 3, 2024
Closed
cm13-github
added a commit
that referenced
this pull request
Nov 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
This PR is a follow-up to #7406 correcting an issue where sentries swapped the shooter and firer vars to fix #7045. It also corrects the erroneous initialization for flamer sentries so now they will actually attribute kills to the sentry and explain in the death message both the sentry and owner.
Explain why it's good for the game
Fixes additional projectiles being fired from humans that placed a shotgun sentry; the shots are supposed to be from the sentry not magically from the player somewhere else. Also improves the death messages for flamer sentry kills and actually attributes kills to the sentry.
Testing Photographs and Procedure
Screenshots & Videos
Changelog
🆑 Drathek
fix: Fixes additional projectiles being fired from humans that placed a shotgun sentry instead of the sentry.
fix: Fixes cause_data for flamer sentries so now kills they make are explained in the message and attributed to the kill counter for the sentry.
/:cl: