Wrong text for overloading #7127
Labels
Good First Issue
Good for newcomers
Oversight
Test your code rigorously only for you to overlook something ultra obvious
Comments
LC4492
added
Oversight
This was referenced Sep 13, 2024
github-merge-queue bot
pushed a commit
that referenced
this issue
Oct 9, 2024
# About the pull request fixes #7127 This if/then/otherwise statement was activating the wrong message when it was overloaded meaning that when you were restoring safety’s then chat would say that you weren’t. switched the then statements around and now it’s working again <!-- Remove this text and explain what the purpose of your PR is. Mention if you have tested your changes. If you changed a map, make sure you used the mapmerge tool. If this is an Issue Correction, you can type "Fixes Issue #169420" to link the PR to the corresponding Issue number #169420. Remember: something that is self-evident to you might not be to others. Explain your rationale fully, even if you feel it goes without saying. --> # Testing Photographs and Procedure <details> <summary>Screenshots & Videos</summary> Put screenshots and videos here with an empty line between the screenshots and the `<details>` tags. </details> # Changelog :cl: fix: fusion reactor overload messages now show correctly /:cl: --------- Co-authored-by: BeagleGaming1 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Testmerges
#6334: 'Xenomorph Endgame' by Git-Nivrak at commit b84244f #6071: '[V] Sorokyne Strata: Expanded Small corridors, removed 3000 unused tiles, Xenos can now weed everything except LZ's and surrounding of LZ's, allow LAZ for CAS inside structures with light blue Areas on Tacmap (glass ceiling hallways)' by Venuska1117 at commit 300a417 #6820: 'Updates close backpack icon' by Blundir at commit e6e1e49 #6808: 'Attachments resprite' by Blundir at commit cc4fe40 #7093: 'ports ipintel subsystem' by harryob at commit 3416fba #7106: 'Flexible Job Icons' by realforest2001 at commit a490c79 #7061: 'Project ARES: Interface Data Proc' by realforest2001 at commit 06f2ec3 #7123: 'Adds the preference to trigger xeno/human abilities with right click instead of middle click or shift click' by Watermelon914 at commit dba26e8 #6860: 'Mentor New Player Markers' by realforest2001 at commit 1457cba
Round ID
No response
Description of the bug
The text for overloading and restoring safeties are reversed for SD (multitooling a generator).
In this case, overloading a reactor says we are "restoring" them, only for the next message to say we DID overload the safeties.
What's the difference with what should have happened?
Should say we are overloading the safeties instead of restoring them.
How do we reproduce this bug?
1.Get fuel to max
2.Multitool a generator to overload it for SD
3.Get wrong text.
...
Issue Bingo
The text was updated successfully, but these errors were encountered: