Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autolathes printing blowtorch with fuel #7310

Closed
3 tasks done
Ansekishokuu opened this issue Oct 13, 2024 · 2 comments
Closed
3 tasks done

Autolathes printing blowtorch with fuel #7310

Ansekishokuu opened this issue Oct 13, 2024 · 2 comments
Labels
Oversight Test your code rigorously only for you to overlook something ultra obvious

Comments

@Ansekishokuu
Copy link
Contributor

Testmerges

#6808: 'Attachments resprite' by Blundir at commit cc4fe40 #6938: 'SHARP Rifle Revived' by Nomoresolvalou at commit 744d618 #7242: 'WIP Yautja Clan TGUI Menu' by realforest2001 at commit cd3b853 #6334: 'Xenomorph Endgame' by Git-Nivrak at commit 1afe9c9 #7280: 'Fix unintended reagent refilling via vendors' by Drulikar at commit c4023e1 #7282: 'stops pilots breaking the bank' by harryob at commit 5d6f909 #7165: 'Fax Responders & Paperwork Prefabs hybrid TM' by realforest2001 at commit decbc8d #7106: 'Flexible Job Icons' by realforest2001 at commit a490c79 #7302: 'Hostile ERT clarity messages' by realforest2001 at commit 417a76f #5925: 'Biosuit Updates' by realforest2001 at commit 875b8f7 #7307: 'TestMerge: Weedable area changes' by Nanu308 at commit 2e91bd2

Round ID

No response

Description of the bug

Autolathes print blowtorches with fuel inside them.
Putting your empty blowtorch inside the autolathe and printing a new one gives you a full one with no extra material cost.

What's the difference with what should have happened?

Autolathes should print empty blowtorches.

How do we reproduce this bug?

1- Print a blowtorch

Optionally:
1- Put your empty blowtorch inside the autolathe
2- Print a new one

Issue Bingo
@Ansekishokuu Ansekishokuu added the Bug Admin events aren't bugs label Oct 13, 2024
@Ansekishokuu
Copy link
Contributor Author

To your knowledge!
Fix PR is ready but i can't send a PR right now, will send later.

@Ansekishokuu Ansekishokuu reopened this Oct 14, 2024
@ItsVyzo ItsVyzo added Oversight Test your code rigorously only for you to overlook something ultra obvious and removed Bug Admin events aren't bugs labels Oct 18, 2024
@Ansekishokuu Ansekishokuu mentioned this issue Oct 27, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Oct 28, 2024
@Ansekishokuu @harryob
Fix blowtorch (#7407)
c00945d 
# About the pull request

Fixes Issue #7310 

Changes tested.
Autolathes now print blowtorches with no fuel inside them. 
Also blowtorches should have a description now.

# Explain why it's good for the game

Infinite welding fuel is bad.
The code has not been touched for over 7 years now and this bug should
have been fixed a long time ago.

# Testing Photographs and Procedure

<details>
<summary>Screenshots & Videos</summary>


https://github.com/user-attachments/assets/9379d4df-827b-4f58-84ff-b170f0b75a7b

</details>


# Changelog

:cl: Ansekishoku

fix: Fixed autolathes printing blowtorches with fuel.
spellcheck: Added description to blowtorches.

/:cl:

---------

Co-authored-by: harryob <[email protected]>
@LC4492
Copy link
Contributor

LC4492 commented Oct 28, 2024

Fixed by #7407

@LC4492 LC4492 closed this as completed Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Oversight Test your code rigorously only for you to overlook something ultra obvious
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ItsVyzo @Ansekishokuu @LC4492