Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix blowtorch #7407

Merged
merged 6 commits into from
Oct 28, 2024
Merged

Fix blowtorch #7407

merged 6 commits into from
Oct 28, 2024

Conversation

Ansekishokuu
Copy link
Contributor

@Ansekishokuu Ansekishokuu commented Oct 27, 2024

About the pull request

Fixes Issue #7310

Changes tested.
Autolathes now print blowtorches with no fuel inside them.
Also blowtorches should have a description now.

Explain why it's good for the game

Infinite welding fuel is bad.
The code has not been touched for over 7 years now and this bug should have been fixed a long time ago.

Testing Photographs and Procedure

Screenshots & Videos
fix.mp4

Changelog

🆑 Ansekishoku

fix: Fixed autolathes printing blowtorches with fuel.
spellcheck: Added description to blowtorches.

/:cl:

@cmss13-ci cmss13-ci bot added Fix Fix one bug, make ten more Grammar and Formatting Fixes the codebase's tpyos and grammatical's errors labels Oct 27, 2024
@JackieEstegado
Copy link
Contributor

Honestly this would be just annoying, maybe make it give back less metal than it costs to make or something instead. Also I am pretty sure this happens with vendors too.

@Ansekishokuu
Copy link
Contributor Author

@JackieEstegado

You can refuel welding tools pretty easily, autolathes printing a new one with fuel inside it makes no sense imo.

Can you explain how it happens with vendors? If you refer to vendors giving out blowtorches with welding fuel inside them, that isn't touched on purpose. I only changed so that autolathes dont print ones with fuel inside them. Blowtorches that are picked up from vendors, inside lockers, etc. are also not changed, the only change being that the printed ones have no fuel inside them.

@JackieEstegado
Copy link
Contributor

@Ansekishokuu Tool storage vendors can be restocked with depleted welders, to then vend full ones.

@Ansekishokuu
Copy link
Contributor Author

@JackieEstegado Thanks for letting me know, will try to solve that whenever i can.

@harryob harryob marked this pull request as draft October 27, 2024 22:30
@Ansekishokuu Ansekishokuu marked this pull request as ready for review October 28, 2024 10:19
@harryob harryob added this pull request to the merge queue Oct 28, 2024
Merged via the queue into cmss13-devs:master with commit c00945d Oct 28, 2024
28 checks passed
cmss13-ci bot added a commit that referenced this pull request Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Fix one bug, make ten more Grammar and Formatting Fixes the codebase's tpyos and grammatical's errors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants