Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yautja Bracer Charging Rework #3456

Merged
merged 13 commits into from
Jul 24, 2023

Conversation

realforest2001
Copy link
Member

@realforest2001 realforest2001 commented May 28, 2023

About the pull request

Changes how bracers recharge, requiring drain from APC in the field. Change made as atomisation from #3271 as part of an ongoing project to make Yautja a more balanced role for what it is.

Explain why it's good for the game

Balances out power usage and makes things more dynamic. Will tie in with cloak not using power but being more vulnerable to the methods to force decloak.

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
add: Yautja bracers can now be recharged from APCs.
remove: Yautja bracers no longer naturally recharge on the colony.
/:cl:

@github-actions github-actions bot added the Feature Feature coder badge label May 28, 2023
code/modules/cm_preds/yaut_bracers.dm Outdated Show resolved Hide resolved
code/modules/cm_preds/yaut_bracers.dm Outdated Show resolved Hide resolved
code/modules/power/apc.dm Outdated Show resolved Hide resolved
code/modules/power/apc.dm Outdated Show resolved Hide resolved
code/modules/power/apc.dm Outdated Show resolved Hide resolved
code/modules/power/apc.dm Outdated Show resolved Hide resolved
code/modules/power/apc.dm Outdated Show resolved Hide resolved
@harryob harryob marked this pull request as draft May 30, 2023 08:59
@realforest2001 realforest2001 marked this pull request as ready for review June 3, 2023 18:08
code/modules/cm_preds/yaut_bracers.dm Outdated Show resolved Hide resolved
code/modules/cm_preds/yaut_bracers.dm Outdated Show resolved Hide resolved
code/modules/cm_preds/yaut_bracers.dm Outdated Show resolved Hide resolved
code/modules/cm_preds/yaut_bracers.dm Outdated Show resolved Hide resolved
code/modules/cm_preds/yaut_bracers.dm Outdated Show resolved Hide resolved
code/modules/cm_preds/yaut_bracers.dm Outdated Show resolved Hide resolved
code/modules/cm_preds/yaut_bracers.dm Outdated Show resolved Hide resolved
code/modules/cm_preds/yaut_bracers.dm Outdated Show resolved Hide resolved
code/modules/cm_preds/yaut_bracers.dm Outdated Show resolved Hide resolved
code/modules/power/apc.dm Show resolved Hide resolved
@harryob harryob marked this pull request as draft June 4, 2023 11:06
realforest2001 and others added 2 commits June 9, 2023 22:43
@realforest2001 realforest2001 marked this pull request as ready for review June 9, 2023 21:53
code/modules/power/apc.dm Outdated Show resolved Hide resolved
@morrowwolf morrowwolf marked this pull request as draft June 12, 2023 20:57
@realforest2001 realforest2001 marked this pull request as ready for review June 17, 2023 17:25
@github-actions
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Jun 25, 2023
@github-actions github-actions bot closed this Jul 6, 2023
@realforest2001 realforest2001 added this to the Yautja Rework milestone Jul 13, 2023
@realforest2001 realforest2001 removed the Stale beg a maintainer to review your PR label Jul 13, 2023
@Mister-moon1
Copy link
Contributor

During the original testing for the pred quality of life TM it was expressed by many that achieving power planetside was, although difficult, possible due to a couple APCs missed by the xenos.
The noticeable oversight was of course the fact of having near enough infinite power shipside due to being able to ping to and from the same APC, the "solution" given was to have the APC destroyed upon siphon along with a 5 minute cooldown

This has led to achieving power groundside almost impossible via siphoning power due to the fact of that one forgotten APC just being destroyed when the yautja gets power, leaving no source of power other than the 5 power per second or so from natural regeneration, when needing 1000 for a simple crystal this is a bit absurd. It also leaves the only other possible option to go shipside and deal with the better but still subpar power regeneration with the best solution to go afk and come back when it is done which i do not find very engaging.

I suggest that the groundside regeneration be doubled to 10 per tick and APCs be reverted to their state of not being broken upon siphon, i believe that the 5 minute cooldown should be enough to not warrant issues coming from this

@Diegoflores31
Copy link
Contributor

Idea for "possible" solution . Add a self recharge device thingy that can be used like like AVP classic one . 10 minute cooldown or more . With a windup of dunno 10 seconds

@morrowwolf
Copy link
Member

Ping me once cloaking PR is merged if I forget.

code/modules/power/apc.dm Outdated Show resolved Hide resolved
code/modules/cm_preds/yaut_bracers.dm Show resolved Hide resolved
code/modules/cm_preds/yaut_bracers.dm Outdated Show resolved Hide resolved
code/modules/cm_preds/yaut_bracers.dm Outdated Show resolved Hide resolved
@harryob harryob marked this pull request as draft July 19, 2023 12:20
@realforest2001 realforest2001 marked this pull request as ready for review July 19, 2023 13:31
Copy link
Member

@harryob harryob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one last nit

code/modules/power/apc.dm Outdated Show resolved Hide resolved
@harryob harryob marked this pull request as draft July 24, 2023 17:14
Co-authored-by: harryob <[email protected]>
@realforest2001 realforest2001 marked this pull request as ready for review July 24, 2023 17:45
@harryob harryob enabled auto-merge July 24, 2023 17:49
@harryob harryob added this pull request to the merge queue Jul 24, 2023
Merged via the queue into cmss13-devs:master with commit 4ef3b9e Jul 24, 2023
github-actions bot added a commit that referenced this pull request Jul 24, 2023
@realforest2001 realforest2001 deleted the forest/pred/bracercharge branch July 24, 2023 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature coder badge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants