-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Impaler Burrower strain (with fixes) #3565
Conversation
You currently have a negative Fix/Feature pull request delta of -7. Maintainers may close this PR at will. Fixing issues or improving the codebase will improve this score. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
groundbreaking changes for the sake of the linter
code/modules/mob/living/carbon/xenomorph/mutators/strains/burrower/impaler.dm
Outdated
Show resolved
Hide resolved
code/modules/mob/living/carbon/xenomorph/abilities/burrower/burrower_powers.dm
Outdated
Show resolved
Hide resolved
code/modules/mob/living/carbon/xenomorph/abilities/burrower/burrower_powers.dm
Outdated
Show resolved
Hide resolved
code/modules/mob/living/carbon/xenomorph/abilities/burrower/burrower_powers.dm
Outdated
Show resolved
Hide resolved
code/modules/mob/living/carbon/xenomorph/abilities/burrower/burrower_powers.dm
Outdated
Show resolved
Hide resolved
code/modules/mob/living/carbon/xenomorph/abilities/burrower/burrower_powers.dm
Outdated
Show resolved
Hide resolved
code/modules/mob/living/carbon/xenomorph/abilities/burrower/burrower_powers.dm
Outdated
Show resolved
Hide resolved
code/modules/mob/living/carbon/xenomorph/abilities/burrower/burrower_powers.dm
Outdated
Show resolved
Hide resolved
yes more rebase fixe dreammaker moment aaaa please final one yas ah Impaler gets tail stabby Update code/modules/mob/living/carbon/xenomorph/mutators/strains/burrower/impaler.dm Co-authored-by: harryob <[email protected]> Apply suggestions from code review Co-authored-by: BeagleGaming1 <[email protected]> Apply suggestions from code review Co-authored-by: BeagleGaming1 <[email protected]> Apply suggestions from code review Co-authored-by: BeagleGaming1 <[email protected]> more applied suggestions (squash edition)
code/modules/mob/living/carbon/xenomorph/abilities/burrower/burrower_abilities.dm
Outdated
Show resolved
Hide resolved
code/modules/mob/living/carbon/xenomorph/abilities/burrower/burrower_abilities.dm
Outdated
Show resolved
Hide resolved
code/modules/mob/living/carbon/xenomorph/abilities/burrower/burrower_abilities.dm
Show resolved
Hide resolved
code/modules/mob/living/carbon/xenomorph/abilities/burrower/burrower_macros.dm
Outdated
Show resolved
Hide resolved
code/modules/mob/living/carbon/xenomorph/abilities/burrower/burrower_powers.dm
Outdated
Show resolved
Hide resolved
code/modules/mob/living/carbon/xenomorph/mutators/strains/burrower/impaler.dm
Outdated
Show resolved
Hide resolved
code/modules/mob/living/carbon/xenomorph/abilities/burrower/burrower_abilities.dm
Outdated
Show resolved
Hide resolved
code/modules/mob/living/carbon/xenomorph/abilities/burrower/burrower_abilities.dm
Outdated
Show resolved
Hide resolved
missed some single letter vars they sure love to hide (single letter vars) lowercasing the fix in changelog actually exists now less redundant
tru
code/modules/mob/living/carbon/xenomorph/abilities/burrower/burrower_powers.dm
Outdated
Show resolved
Hide resolved
code/modules/mob/living/carbon/xenomorph/abilities/burrower/burrower_powers.dm
Outdated
Show resolved
Hide resolved
code/modules/mob/living/carbon/xenomorph/abilities/burrower/burrower_powers.dm
Outdated
Show resolved
Hide resolved
code/modules/mob/living/carbon/xenomorph/abilities/burrower/burrower_abilities.dm
Outdated
Show resolved
Hide resolved
code/modules/mob/living/carbon/xenomorph/abilities/burrower/burrower_powers.dm
Outdated
Show resolved
Hide resolved
code/modules/mob/living/carbon/xenomorph/abilities/burrower/burrower_powers.dm
Outdated
Show resolved
Hide resolved
code/modules/mob/living/carbon/xenomorph/abilities/burrower/burrower_powers.dm
Outdated
Show resolved
Hide resolved
code/modules/mob/living/carbon/xenomorph/abilities/burrower/burrower_powers.dm
Outdated
Show resolved
Hide resolved
code/modules/mob/living/carbon/xenomorph/abilities/burrower/burrower_powers.dm
Outdated
Show resolved
Hide resolved
code/modules/mob/living/carbon/xenomorph/abilities/burrower/burrower_powers.dm
Outdated
Show resolved
Hide resolved
Co-authored-by: harryob <[email protected]>
intended, spikes can only go through window frames/windows and airlocks. |
yes, but if you use "sunked tail" when you are foryfied (or not), it don't work if you have membrane in front of you, it say something obscure it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Heya!
I got some questions for ya I'd like you to fill out:
Gameplay:
Does it feel good to use?
Does it feel good to play against?
Does it affect other systems?
Roleplay:
Does it increase immersion?
Does it increase communication/interaction between players?
Simulation:
Does it fit in the CM universe aesthetically?
Does it fit in the lore of CM?
Bear in mind, these don't all need to be yes. Just curious what your take on it is.
Gameplay: Does it feel good to use? Does it feel good to play against? Does it affect other systems? Its attacks are telegraphed and readable, have time to react against and are only strong when the strain uses the ability which locks them in place which makes them vulnerable to attacks, there are two ways of counterplay against the strain, one is more of a skill equals reward which is sprite click shooting the borrower to damage it, the other is removing the weeds to force it out. Playing against is equal to a boiler, it is annoying but not impossible. as time goes on, players will be able to adapt to the meta against the strain. The strain has been nerfed several times up until this iteration. The only existing issue regarding it is the way how fire affects weeds, it does not instantly remove them which means the borrower has a grace period of being able to move across the flamed tiles before the weeds go away and not be forcibly surfaced, so the only way of instantly flushing them out is through meleeing the tiles, spraying chemicals containing a specific property that removes weeds and explosions. I do not want to change how fire affects weeds as that is a massive balance change but If I'm gonna throw my opinion on this is that yes, fire should instantly remove weeds. (except green) Roleplay: Does it increase immersion? Does it increase communication/interaction between players? The strain is more immersive than the original that's for sure, as for the second question I am unable to answer in full confidence due to a lack of observational data, in theory, it should be like a boiler-lite in terms of communication/interaction between the xenomorphs. Simulation: Does it fit in the CM universe aesthetically? Does it fit in the lore of CM? Since Burrowers do not actually exist in the Aliens media, all we have is CM's iteration of what a Burrower is. the original strain of the Burrower is a combat support caste, primarily intended to assist xenomorphs fast traveling around the map with tunnels, fortifying key locations and assisting backliners in general, it is able to solo but not as effective as a lurker against more than 1-2 marines. The Impaler strain is the opposite, instead of combat supporting backliners, it is now a frontline combat support caste (while the original could assist in frontlines, it's usually a waste of their potential). Its advantage is helping in defending the xeno side of the frontline if marines push by slowing them down through its telegraphed attacks and when xenos start advancing, it provides additional pressure to the marines by acting as sort of a mobile environmental hazard. |
I think another way to solve flame vs. weeds issue is just to make impaler vulnerable to fire even if burrowed. So impaler would be forced to disengage, surface and resist. This will create an easy and effective way to fight impalers and probably reduce the amount of salt. |
Maybe add more alpha pixels to the burrowed state so it is easier to hit instead. |
its like said to burn whole fish in water if only their fin stick out of water. Just make fire deal damage to them if they on burning tiles (when burrowed) but don't ignite burrower (something like heat damage, with make more sense) And to say, when weeds are on fire, they dissapear, so if you on burning weeds and they "die" from fire, then you get instant unborrowed and very easy target. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sprites approved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, this is not gonna be what anyone wants to hear: I'm not sure I like the strain.
I feel it is frustrating to fight.
I feel adding more ranged options for xenos is the opposite of the direction we should be going.
I feel the lurker sounds and inspiration are a little too on the nose for our setting.
Some of this I can overlook. The one thing I can't overlook is another ranged strain for xenos. I'm happy to see spikes or moving around underground as it is but it has to be much closer range.
If you can overcome those requirements we can take a look again. Sadly, this is going to require pretty much an entire rework.
This comment was marked as off-topic.
This comment was marked as off-topic.
Alright, since you don't wish for a ranged strain and I am not going to change the kit of the strain to compromise. This project is closed indefinitely. Some of the features here will be atomized into a separate PR as they on their own are worthy to be included (fixes being obviously one of them) |
About the pull request
First of all, thank you Kugamo for making the sprites for the strain and its effects.
https://streamable.com/4m3rbr (some things are changed since this video)
A burrower strain that can deal damage while burrowed, causing enemies to have to be creative when attacking, removing its weeds will force it to surface.
Impaler abilities:
Burrowed Spikes:
Description: Sends out fast spikes in a direction that hits tile by tile.
Cost: 50 Plasma
Cooldown: 8 Seconds.
Range: 5 Tiles
Damage: 35
Can be used while burrowed.
Sunken Tail:
Description: After a windup, strikes the targeted area damaging anyone in the tile.
Cost: 100 Plasma
Cooldown: 13 seconds.
Range: 7
Damage: 60
Windup: .8 Seconds
Ensconce:
Description: After a windup, go halfway into the ground in a fortified stance (prevents you from moving) which increases your vision range by 3, increases your Burrowed spikes ability range by 2, increases your Sunken Tail ability range by 2, and damage on both abilities by 30.
Modifies Sunken Tail to do an AoE effect:
https://streamable.com/xy0tq1 (middle is full damage + ensconce'ed damage bonus, edges are normal damage)
Cost: None
Cooldown: 3 Seconds
Buffs: Armor deflection increased by 25 and armor explosive resistance increased by 50 and small explosives cannot stun the target while in the stance.
Base Tail Stab:
Can be used while burrowed.
Explain why it's good for the game
New (actually balanced on launch) xeno content which they need.
Testing Photographs and Procedure
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>
tags.Changelog
🆑 Unknownity, Kugamo
add: Added new strain for the Burrower, "Impaler".
fix: Fixed burrowed mobs being able to be targeted by sentries, mines and SG autofire.
fix: Fixed burrowed mobs being able to grab mobs on the surface.
fix: Fixed burrowed mobs being able to resist while burrowed.
fix: Fixed burrowers taking damage from direct flame and shrapnel from explosions.
fix: Fixed burrowers being able to get slashed from enemy Xenos on the surface.
fix: Fixed burrowers unburrow stun to now properly target and stun enemy Xenos.
soundadd: Added sounds for base and Impaler burrower for burrowing and unburrowing, added sounds for Impaler burrower's attacks.
imageadd: Added sprites and effects for Impaler burrower by Kugamo.
/:cl: