Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor the code by addding a bunch of subtype for floor type. #3581

Closed

Conversation

Huffie56
Copy link
Contributor

@Huffie56 Huffie56 commented Jun 9, 2023

About the pull request

create many subtype to clean dmm code

Explain why it's good for the game

because making sub-type is good for now and the future...

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
refactor: create many sub-type for item to clean the code.
/:cl:

@github-actions github-actions bot added Mapping did you remember to save in tgm format? Refactor Make the code harder to read labels Jun 9, 2023
@Huffie56 Huffie56 marked this pull request as ready for review June 11, 2023 16:21
@Huffie56 Huffie56 marked this pull request as draft June 11, 2023 16:22
@Huffie56
Copy link
Contributor Author

with another PR i would probably be able to make all the subtype for floor.
image

@Huffie56 Huffie56 marked this pull request as ready for review June 11, 2023 17:05
@Huffie56
Copy link
Contributor Author

checked all the map for change should be fine...

@Huffie56 Huffie56 requested a review from harryob June 13, 2023 17:36
@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Jun 14, 2023
@github-actions
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Jun 22, 2023
@Huffie56
Copy link
Contributor Author

this is going to be pain to fix...

@Huffie56 Huffie56 marked this pull request as draft June 23, 2023 13:59
 'upstream/master' into
  subtypesfor_turf_open_floor
@Huffie56 Huffie56 marked this pull request as ready for review June 23, 2023 14:47
@Huffie56 Huffie56 requested a review from fira as a code owner June 23, 2023 14:47
@github-actions github-actions bot removed the Stale beg a maintainer to review your PR label Jun 24, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 1, 2023

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Jul 1, 2023
@github-actions github-actions bot closed this Jul 9, 2023
@Huffie56 Huffie56 deleted the subtypesfor_turf_open_floor branch July 16, 2023 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mapping did you remember to save in tgm format? Merge Conflict PR can't be merged because it touched too much code Refactor Make the code harder to read Stale beg a maintainer to review your PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants