Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cluster OB now respects if a hive core is created while it is firing. #3600

Merged
merged 3 commits into from
Jun 27, 2023

Conversation

TheGamerdk
Copy link
Contributor

About the pull request

It checks for OB protection on the turf now. It'll remove the turf from consideration and try a different one. If no valid turfs remain the OB stops.

Explain why it's good for the game

Seems fair enough, very niche case though.

Testing Photographs and Procedure

Changelog

🆑
balance: Cluster OBs will now no longer hit turfs that have gotten OB protection after the initial OB was fired.
/:cl:

@github-actions github-actions bot added the Balance You need to be a professional veteran game maintainer to comprehend what is being done here. label Jun 11, 2023
Copy link
Member

@fira fira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd think the core should just eat the shell because otherwise this could deflect shells into a concentrated barrage, but well, alright

@TheGamerdk
Copy link
Contributor Author

I'd think the core should just eat the shell because otherwise this could deflect shells into a concentrated barrage, but well, alright

We can do that too, but then you'd lose out on the part of the OB hitting the non-protected part. As you say, concentrated.

Copy link
Member

@morrowwolf morrowwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with Fira. This is gonna take some moving around.

Add all the turfs in the range, then do the regular picking and fire_in_a_hole() calls.

In fire_in_a_hole() do the check for if the turf is protected by a pylon and then eat the explosion instead of having it all bottled up.

Maintaining density for this stuff is important for balance, surprised it was like this for so long.

@morrowwolf morrowwolf marked this pull request as draft June 13, 2023 11:13
@TheGamerdk TheGamerdk marked this pull request as ready for review June 19, 2023 17:39
@TheGamerdk
Copy link
Contributor Author

I agree with Fira. This is gonna take some moving around.

Add all the turfs in the range, then do the regular picking and fire_in_a_hole() calls.

In fire_in_a_hole() do the check for if the turf is protected by a pylon and then eat the explosion instead of having it all bottled up.

Maintaining density for this stuff is important for balance, surprised it was like this for so long.

misread this request, oops

@morrowwolf morrowwolf added this pull request to the merge queue Jun 27, 2023
Merged via the queue into cmss13-devs:master with commit be616f3 Jun 27, 2023
cm13-github added a commit that referenced this pull request Jun 27, 2023
github-actions bot added a commit that referenced this pull request Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance You need to be a professional veteran game maintainer to comprehend what is being done here.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants