Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes the MP Beret clickable. #3622

Merged
merged 1 commit into from
Jul 1, 2023

Conversation

theselfish
Copy link
Contributor

@theselfish theselfish commented Jun 14, 2023

About the pull request

Title.

Explain why it's good for the game

Trying to click a tiny little sprite to take off a piece of headware is bad. Seriously.

Other hats that suffer from this that I DID NOT fix because I'm not a spriter and I cannot make new sprites. (This one is from an old version of the dmi file that I had when I made my previous PRs);

-Normal and tan berets.
-Boonie Hats
-Doo-Rags.
-Patrol Caps

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
qol: Made the MP beret to be clickable.
imageadd: Updated the MP beret obj sprite to be easier to click.
/:cl:

@github-actions github-actions bot added Sprites Remove the soul from the game. Fix Fix one bug, make ten more labels Jun 14, 2023
@Drulikar Drulikar removed the Fix Fix one bug, make ten more label Jun 14, 2023
@github-actions
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Jun 22, 2023
@theselfish
Copy link
Contributor Author

@harryob Since the PR never automatically pinged a maintainer.

@harryob harryob requested a review from a team June 22, 2023 10:11
@github-actions github-actions bot removed the Stale beg a maintainer to review your PR label Jun 23, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 1, 2023

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Jul 1, 2023
Copy link
Contributor

@nauticall nauticall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sprites fine 👍

@nauticall nauticall added Sprites Approved confirmed no stray pixels and removed Stale beg a maintainer to review your PR labels Jul 1, 2023
@BeagleGaming1 BeagleGaming1 added this pull request to the merge queue Jul 1, 2023
Merged via the queue into cmss13-devs:master with commit 840be46 Jul 1, 2023
cm13-github added a commit that referenced this pull request Jul 1, 2023
github-actions bot added a commit that referenced this pull request Jul 1, 2023
Metro-Dweller pushed a commit to Metro-Dweller/test that referenced this pull request Jul 1, 2023
@theselfish theselfish deleted the beretbetterer branch July 1, 2023 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Sprites Approved confirmed no stray pixels Sprites Remove the soul from the game.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants