Fix erronous flamer_tank is empty messages and add sfx to empty canister verb #3623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… was transferred because the container is full.
github-actions
bot
added
Fix
harryob
requested changes
Jun 15, 2023
Co-authored-by: harryob <[email protected]>
|
|
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
harryob
approved these changes
Jun 23, 2023
cm13-github
added a commit
that referenced
this pull request
Jun 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
This PR is a followup to #3357 to fix an incorrect message discovered when reviewing that PR as well as to make the existing empty_reagents verb behave the same as the empty_reagents verb added in that PR.
Explain why it's good for the game
The messages sent to the user should be accurate, and verbs should have consistent behavior.
Testing Photographs and Procedure
Screenshots & Videos
refill.mp4
Changelog
🆑 Drathek
fix: Fixed erroneous is empty messages when inserting tanks into a flamer pack.
soundadd: Added the refill sfx when using the empty canister verb on flamer tanks.
/:cl: