Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed the ability to plant c4 on zombies #3637

Closed
wants to merge 9 commits into from
Closed

removed the ability to plant c4 on zombies #3637

wants to merge 9 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Jun 15, 2023

About the pull request

Removes the ability to plant c4 on zombies.

Explain why it's good for the game

"Player c4d three zombies, says not to do so in the join message as well as other places by Somebody (SomeRole) on 2023-06-15 05:43:53"

Changelog

🆑
fix: removed the ability to c4 zombies.
/:cl:

@github-actions github-actions bot added the Code Improvement Make the code longer label Jun 15, 2023
@github-actions
Copy link
Contributor

You currently have a negative Fix/Feature pull request delta of -2. Maintainers may close this PR at will. Fixing issues or improving the codebase will improve this score.

code/game/objects/items/explosives/plastic.dm Outdated Show resolved Hide resolved
code/game/objects/items/explosives/plastic.dm Outdated Show resolved Hide resolved
@harryob harryob marked this pull request as draft June 15, 2023 08:10
@ghost ghost marked this pull request as ready for review June 15, 2023 08:33
@ghost ghost requested a review from harryob June 15, 2023 08:39
@github-actions
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Jun 25, 2023
@Drulikar Drulikar added Fix Fix one bug, make ten more and removed Code Improvement Make the code longer labels Jun 28, 2023
Copy link
Contributor

@Drulikar Drulikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code as it is fine; but lets just make this an admin toggle instead (so also check if that setting is true before this iszombie check). Not only was the quote regarding an event rule, but this honestly is only an issue for the first few zombies. I don't have any strong feelings one way or another what the default is.

@Drulikar Drulikar marked this pull request as draft June 28, 2023 07:33
@github-actions github-actions bot closed this Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Fix one bug, make ten more Stale beg a maintainer to review your PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants