-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Bunker Buster CAS Missile: GBU-67-EP 'Paveway XXI' #3648
Conversation
You currently have a negative Fix/Feature pull request delta of -5. Maintainers may close this PR at will. Fixing issues or improving the codebase will improve this score. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed cavebreaker var, unused
Fixed internal name to align with detonate_on name
|
||
/obj/structure/ship_ammo/rocket/bunkerbuster/detonate_on(turf/impact) | ||
impact.ceiling_debris_check(5) | ||
spawn(5) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nevernevernever use spawn()
use a timer instead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So every single other weapon in this .dm functions with this code, I'm just duplicating preexisting code. Overhauling all of the CAS weapons seems beyond the scope of this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
spawn(5) replaced with sleep(5)
travel time update
replaced the spawn()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed spawn()
This genuinely looks better than sleep. Co-authored-by: harryob <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think breaching the CAS barrier will be a good idea at this time. It's sort of "sacred" to a degree and a change like this would be a huge deal even if rare and expensive to do. I'm sorry you put so much time into it for it to end this way 😞
About the pull request
This adds a new missile to CAS which allows it to do -something- when the fight is in caves.
Pros:
Cons:
Explain why it's good for the game
Once the fight moves into caves, CAS pilots have nothing to do unless the IOs have managed to not all get capped in the first 30 minutes. Even then they become a Fulton ferry which can be quite dull. This lets CAS pilots actually show up to LV operations. Additionally, it gives one of the more uncommon weapon types on CAS more reason to exist as it gives capability that the other, more popular weapons do not have.
Testing Photographs and Procedure
Tested via the following test cases:
Outside of Caves:
Keeper II: Fires successfully!
Paveway XXI: Fires successfully!
Inside of Caves:
Keeper II: Does not fire!
Paveway XXI: Fires successfully!
Inside of Caves, and under Hivecore:
Keeper II: Does not fire!
Paveway XXI: Does not fire!
Changelog
🆑
add: Added GBU-67-EP 'Paveway XXI' bunker busting missile.
/:cl: