Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Bunker Buster CAS Missile: GBU-67-EP 'Paveway XXI' #3648

Closed
wants to merge 22 commits into from
Closed

New Bunker Buster CAS Missile: GBU-67-EP 'Paveway XXI' #3648

wants to merge 22 commits into from

Conversation

blackdragonTOW
Copy link
Contributor

@blackdragonTOW blackdragonTOW commented Jun 16, 2023

About the pull request

This adds a new missile to CAS which allows it to do -something- when the fight is in caves.

Pros:

  • Can be fired into caves.

Cons:

  • 2x the points of a Keeper II
  • Exact same explosive profile of a Keeper II
  • Can only be fired Direct, no Fire Missions.
  • Requires a Missile Launcher, which is somewhat uncommon in the 2 by 2 meta that most CAS pilots take, with lasers, minis, or GAUs.
  • Firing it outside of caves is a massive points waste as it's worth two Keeper IIs
  • Still susceptible to Hivecore coverage.

Explain why it's good for the game

Once the fight moves into caves, CAS pilots have nothing to do unless the IOs have managed to not all get capped in the first 30 minutes. Even then they become a Fulton ferry which can be quite dull. This lets CAS pilots actually show up to LV operations. Additionally, it gives one of the more uncommon weapon types on CAS more reason to exist as it gives capability that the other, more popular weapons do not have.

Testing Photographs and Procedure

Tested via the following test cases:
Outside of Caves:
Keeper II: Fires successfully!
Paveway XXI: Fires successfully!

Inside of Caves:
Keeper II: Does not fire!
Paveway XXI: Fires successfully!

Inside of Caves, and under Hivecore:
Keeper II: Does not fire!
Paveway XXI: Does not fire!

Capture

Changelog

🆑
add: Added GBU-67-EP 'Paveway XXI' bunker busting missile.
/:cl:

@github-actions
Copy link
Contributor

You currently have a negative Fix/Feature pull request delta of -5. Maintainers may close this PR at will. Fixing issues or improving the codebase will improve this score.

@github-actions github-actions bot added Sprites Remove the soul from the game. Feature Feature coder badge labels Jun 16, 2023
@fira fira added the Balance You need to be a professional veteran game maintainer to comprehend what is being done here. label Jun 16, 2023
Copy link
Contributor Author

@blackdragonTOW blackdragonTOW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed cavebreaker var, unused
Fixed internal name to align with detonate_on name

code/modules/cm_marines/dropship_ammo.dm Outdated Show resolved Hide resolved

/obj/structure/ship_ammo/rocket/bunkerbuster/detonate_on(turf/impact)
impact.ceiling_debris_check(5)
spawn(5)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nevernevernever use spawn()
use a timer instead

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So every single other weapon in this .dm functions with this code, I'm just duplicating preexisting code. Overhauling all of the CAS weapons seems beyond the scope of this PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spawn(5) replaced with sleep(5)

@Zonespace27 Zonespace27 marked this pull request as draft June 17, 2023 06:20
travel time update
replaced the spawn()
Copy link
Contributor Author

@blackdragonTOW blackdragonTOW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed spawn()

@blackdragonTOW blackdragonTOW requested a review from fira June 20, 2023 21:24
@blackdragonTOW blackdragonTOW marked this pull request as ready for review June 20, 2023 23:08
code/modules/cm_marines/dropship_ammo.dm Outdated Show resolved Hide resolved
@harryob harryob marked this pull request as draft June 24, 2023 08:06
blackdragonTOW and others added 2 commits June 24, 2023 01:40
Copy link
Member

@morrowwolf morrowwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think breaching the CAS barrier will be a good idea at this time. It's sort of "sacred" to a degree and a change like this would be a huge deal even if rare and expensive to do. I'm sorry you put so much time into it for it to end this way 😞

@morrowwolf morrowwolf closed this Jun 24, 2023
@blackdragonTOW
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Feature Feature coder badge Sprites Remove the soul from the game.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants