living zombies have a chance to get decapitated by blades #3655
Conversation
|
You currently have a negative Fix/Feature pull request delta of -2. Maintainers may close this PR at will. Fixing issues or improving the codebase will improve this score. |
github-actions
bot
added
Sound
ghost
changed the title
There was a problem hiding this comment.
This is done pretty much fundamentally wrong.
Code for delimbing/decapitating should be done via a component on zombies (/datum/component/melee_delimbable or similar), and it should be triggered via signals, not by overriding the attack() of the appropriate weapons
ping me on discord if you have questions
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
ghost
closed this
About the pull request
living zombies now have a 10% chance of getting decapitated when hit in the head with a machete, and 20% chance when hit with a katana.
Explain why it's good for the game
rick grimes gaming
Changelog
🆑
add: added a chance for zombies to get decapitated when struck with a machete or katana.
add: added a new slicing sound
/:cl: