Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARES will now announce how many Foxtrot marines woke up #3675

Merged
merged 10 commits into from
Jun 30, 2023

Conversation

TheGamerdk
Copy link
Contributor

@TheGamerdk TheGamerdk commented Jun 19, 2023

About the pull request

It's neat to be able to see how many Foxtrot marines woke up at a glance. This also means you know when they've woken up.

Explain why it's good for the game

Means CIC can actually know when, and how many, foxtrot woke up, at a glance.

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
add: ARES will announce how many Foxtrot marines that woke up.
/:cl:

@github-actions github-actions bot added the Feature Feature coder badge label Jun 19, 2023
@ihatethisengine
Copy link
Contributor

It's better to make foxtrot not being dependable on ghosts and spawn not taken marines as freed mobs, so we won't have situations like only 3 cryorines wake up.

@TheGamerdk
Copy link
Contributor Author

It's better to make foxtrot not being dependable on ghosts and spawn not taken marines as freed mobs, so we won't have situations like only 3 cryorines wake up.

Absolutely, but totally unrelated to this PR

Copy link
Member

@harryob harryob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i love null safetty

code/datums/emergency_calls/cryo_marines.dm Outdated Show resolved Hide resolved
code/datums/emergency_calls/cryo_marines.dm Outdated Show resolved Hide resolved
@harryob harryob marked this pull request as draft June 24, 2023 07:38
@TheGamerdk TheGamerdk marked this pull request as ready for review June 25, 2023 09:16
Copy link
Contributor

@Drulikar Drulikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This implementation should also apply to /datum/emergency_call/cryo_squad_equipped not just /datum/emergency_call/cryo_squad

code/datums/emergency_calls/cryo_marines.dm Outdated Show resolved Hide resolved
code/datums/emergency_calls/cryo_marines.dm Outdated Show resolved Hide resolved
@Drulikar Drulikar marked this pull request as draft June 26, 2023 09:13
@TheGamerdk TheGamerdk marked this pull request as ready for review June 26, 2023 19:17
@Drulikar
Copy link
Contributor

This implementation should also apply to /datum/emergency_call/cryo_squad_equipped not just /datum/emergency_call/cryo_squad

@Drulikar Drulikar marked this pull request as draft June 28, 2023 07:59
@TheGamerdk TheGamerdk marked this pull request as ready for review June 29, 2023 20:35
@Drulikar Drulikar added this pull request to the merge queue Jun 30, 2023
Merged via the queue into cmss13-devs:master with commit 21dc6cd Jun 30, 2023
28 checks passed
github-actions bot added a commit that referenced this pull request Jun 30, 2023
cm13-github added a commit that referenced this pull request Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature coder badge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants