Fix larva doubling when banished and returned to core #3708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fira
approved these changes
Jun 24, 2023
cm13-github
added a commit
that referenced
this pull request
Jun 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
This PR fixes an oversight brought up by TheGamer01 where banishing larva can double stored larva because banishment rewards it on death, and if there is still a body that body can also be returned to core. Now returning banished larva just has the same to_chat and effect as regular larva, but there is no additional larva granted.
Also note that readmitting a dead xeno doesn't change the banished status on the mob (if you want to test be sure to set the ckey of the mob to something other than you).
Explain why it's good for the game
No exploiting banishment please.
Testing Photographs and Procedure
Screenshots & Videos
Changelog
🆑 Drathek
fix: Fix a possibility of banished larva refunding double the larva
/:cl: