Dropship Missile Refactor #3732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You currently have a negative Fix/Feature pull request delta of -4. Maintainers may close this PR at will. Fixing issues or improving the codebase will improve this score. |
...yes, I know
|
uh, wouldn't the fire also need to be delayed? |
Probably. Added timers to them as well. |
|
Your Fix/Feature pull request delta is now above zero (2). Feel free to make Feature/Balance PRs. |
cm13-github
added a commit
that referenced
this pull request
Jul 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Refactors Dropship Missiles to not use Spawn().
Explain why it's good for the game
While proposing a new CAS feature, this part of the code uses a function we shouldn't be using. With a suggestion from Harry I simply swapped out the parts that we could replace without having to do a bigger overhaul.
Testing Photographs and Procedure
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>tags.Changelog
🆑
refactor: refactored dropship_ammo so that missiles don't use Spawn()
/:cl: