-
Notifications
You must be signed in to change notification settings - Fork 522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
XM88 Spotter Variant for spotter #3733
Changes from all commits
65d5e94
9e2e865
f22fcb6
f9a521b
b8d6149
1eee18a
1583a70
339d378
9689f5c
08b0599
0b301da
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -74,6 +74,28 @@ Similar to shotguns.dm but not exactly. | |
max_rounds = 9 | ||
chamber_closed = 0 | ||
|
||
// This is the internal magazine of the spotter XM rifle | ||
/obj/item/ammo_magazine/internal/lever_action/xm88/spotter | ||
name = "\improper XM88 spotter rifle internal magazine" | ||
desc = "If you see this something went wrong and the world is ending!!" | ||
icon = 'icons/obj/items/weapons/guns/ammo_by_faction/uscm.dmi' | ||
icon_state = "458-box" | ||
item_state = "458-box" | ||
default_ammo = /datum/ammo/bullet/lever_action/tracker | ||
caliber = ".458 tracker" | ||
gun_type = /obj/item/weapon/gun/lever_action/xm88/spotter | ||
max_rounds = 1 | ||
|
||
/obj/item/ammo_magazine/internal/lever_action/xm88/spotter/Initialize(mapload, spawn_empty) | ||
. = ..() | ||
src.color = "#FFCC00" // Yes recoloring things is the new coder sprites what about it | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This one shouldn't be visible so why change the color? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is just a way to recolor the child one step below. I can change this if really needed and I don't see this making any impact. |
||
|
||
// This si the box that comes in the spotter kit | ||
/obj/item/ammo_magazine/internal/lever_action/xm88/spotter/box | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Don't use internal magazines for this, these are meant for internal firearms usage (holding rounds as a revolver barrel or shotgun tube, etc) and not as usable items There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Funny enough the reason that I put that in there is intentional if I remove the internal it causes the box to spawn fine but the rounds inside the box will be the SOCOM rounds not the tracer rounds. Maybe some kind of bug with how the parents over-write ammo box contents but the way I solved this was to change the parent before we get to lever_action and "internal" works for my needs. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. See |
||
name = "box of .458 tracker rounds" | ||
desc = "A box filled with handfuls of .458 tracker rounds, designed for use with the XM88 spotter rifle." | ||
max_rounds = 40 | ||
|
||
//------------------------------------------------------- | ||
|
||
/* | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mirror'ing what Fira said, having this just set at 2000 looks hyper cursed.