Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metalfoam speed improvement #3741

Merged
merged 1 commit into from
Jul 5, 2023
Merged

Conversation

coffeelauer
Copy link
Contributor

@coffeelauer coffeelauer commented Jun 27, 2023

About the pull request

Makes metal foam solidify faster, applies to both regular and OT variants

Changes tested, cuts down the time it takes for metal foam to solidify to roughly a third of before.

Explain why it's good for the game

Metal foam is completely irrelevant in the current state of the game aside from lifeboat memes, making it faster could open up a niche for it.

Changelog

🆑 thatoneyeeter
balance: metal foam now becomes solid faster
/:cl:

@github-actions github-actions bot added the Code Improvement Make the code longer label Jun 27, 2023
@Drulikar Drulikar added Balance You need to be a professional veteran game maintainer to comprehend what is being done here. and removed Code Improvement Make the code longer labels Jun 27, 2023
Copy link
Contributor

@Drulikar Drulikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is obviously fine; but needs balance approval (and I think it already had tentative approval?).

@github-actions
Copy link
Contributor

github-actions bot commented Jul 5, 2023

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Jul 5, 2023
@morrowwolf morrowwolf added this pull request to the merge queue Jul 5, 2023
Merged via the queue into cmss13-devs:master with commit 795b0c8 Jul 5, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 5, 2023

Your Fix/Feature pull request is currently below zero (-2). Maintainers may close future Feature/Balance PRs. Fixing issues or helping to improve the codebase will raise this score.

morrowwolf pushed a commit to morrowwolf/cmss13 that referenced this pull request Jul 5, 2023
@lunarflu lunarflu mentioned this pull request Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Stale beg a maintainer to review your PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants