Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defender and Crusher tail smash has a 1% chance of doing a BONK! sound instead. #3750

Merged
merged 3 commits into from
Jul 6, 2023

Conversation

Diegoflores31
Copy link
Contributor

@Diegoflores31 Diegoflores31 commented Jun 28, 2023

About the pull request

Defender and Crusher tail smash has a 1% chance of doing a BONK! sound instead.

Explain why it's good for the game

its one of those fun occasional things it will be cool for gameplay

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
add: Defender Tail Slam has a 1% chance to do a BONK sound instead.
/:cl:

@github-actions github-actions bot added Sound Blast 5 minutes of bass boosted music to our players Feature Feature coder badge labels Jun 28, 2023
@harryob harryob changed the title Bonk! Defender and Crusher tail smash has a 1% chance of doing a BONK! sound instead. Jun 28, 2023
Copy link
Contributor

@Zonespace27 Zonespace27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where is this sound sourced from?

@Diegoflores31
Copy link
Contributor Author

where is this sound sourced from?

Youtube , pretty sure its a generic bonk

@Diegoflores31
Copy link
Contributor Author

Bruh i pressed close with comment 💀

@Drulikar
Copy link
Contributor

Maybe consider a more iconic, and also creative commons sound: https://freesound.org/people/thecoolcookie17/sounds/573047/ You just ought to trim the initial wait in something like audacity.

@realforest2001 realforest2001 marked this pull request as draft June 28, 2023 18:23
@Diegoflores31 Diegoflores31 marked this pull request as ready for review June 28, 2023 22:38
@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2023

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Jul 6, 2023
@Drulikar Drulikar added this pull request to the merge queue Jul 6, 2023
Merged via the queue into cmss13-devs:master with commit bf67858 Jul 6, 2023
28 checks passed
cm13-github added a commit that referenced this pull request Jul 6, 2023
github-actions bot added a commit that referenced this pull request Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature coder badge Sound Blast 5 minutes of bass boosted music to our players Stale beg a maintainer to review your PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants