Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARES now notifies Working Joes of tickets #3769

Closed
wants to merge 1 commit into from

Conversation

Ben10083
Copy link
Contributor

@Ben10083 Ben10083 commented Jun 29, 2023

About the pull request

APOLLO tickets such as maintenance tickets now are assigned a unique "ID' (IE: # 0192) with first number being access level.
ARES notifies Working Joes over APOLLO link upon ticket creation

Feedback greatly appreciated over the code, especially for forward facing changes such as how ARES should notify Joes.

Explain why it's good for the game

A Ticket ID gives others, especially working Joes, an easy way to reference a ticket (WJ#0103: Assigned to ticket # 0294), and notifying them over APOLLO link allows Joes to know about active tickets without having to check the APOLLO maintenance console.

Testing Photographs and Procedure

Screenshots & Videos

image
APOLLO notif

image
Modified maintenance ticket screen

Changelog

🆑
add: Tickets made in APOLLO maintenance console now have a unique ID identifier.
add: ARES now notifies Working Joes when a ticket has been created.
/:cl:

@github-actions github-actions bot added UI deletes nanoui/html Feature Feature coder badge labels Jun 29, 2023
@Ben10083 Ben10083 changed the title APOLLO now notifies Working Joes ARES now notifies Working Joes of tickets Jun 29, 2023
@realforest2001 realforest2001 added the Do Not Merge If you merge this PR, I will annihilate you label Jun 29, 2023
@realforest2001
Copy link
Member

As of present, handling majority of this myself already in another PR I'm yet to push so going to tag as DNM.
Announcing every ticket is not something I want happening, as it should only be directly alerting priorites.

Will discuss with you more directly when I'm free as I appreciate the interest and effort on this & any ideas you have for the ARES/APOLLO project(s).

Not closing the PR directly however as I consider that to be a conflict of interest. We can discuss in depth when I finish work tomorrow.

@Ben10083
Copy link
Contributor Author

Ben10083 commented Jul 3, 2023

This has been handled satisfactorily by this PR, will close. #3783

@Ben10083 Ben10083 closed this Jul 3, 2023
@Ben10083 Ben10083 deleted the APOLLO_ticket_stuff branch July 11, 2023 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Do Not Merge If you merge this PR, I will annihilate you Feature Feature coder badge UI deletes nanoui/html
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants