Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Big Red PMC Crash Changes (feat. Surv Goon M41 Fix) #3777

Merged
merged 2 commits into from
Jul 19, 2023

Conversation

toolmind
Copy link
Contributor

@toolmind toolmind commented Jul 1, 2023

About the pull request

This PR adds a PMC medic and PMC engineer to the crash on Big Red, and also makes unique equipment presets + skill presets for them so they don't spawn in with the overpowered PMC ERT gear or skills. It also gives the goon survivors (the ones on LV) their awesome white M41As back. I tested the presets and the goons, both worked fine. Haven't tested the insert itself, but it should work perfectly fine.

my gbp is so fucked

Explain why it's good for the game

I promised I'd get around to doing this for this insert like 2 months ago. My reasoning is basically the same as for the CLF ship. Not having a medic or an engineer on the team means you're forced to mindlessly roam with no options for strategizing with your team. Lacking anyone that can revive you or make barricades/hack doors to protect you discourages teamwork and encourages just running off to go hide in a locker somewhere. Super minor change but I also gave the regular PMC survivors five-slot lightweight packs because they look cooler than the leather satchels and fit with the PMC outfit more. There's no gameplay advantage between the two.

I'm 99% sure the goon survivors' corporate M41As were removed by mistake. They looked cool (snow camo is awesome) and provided 0 advantages besides that, in fact it had DISadvantages because it spawned without a UGL. Could I atomize it into its own PR? Sure. Is it really worth its own PR? Not really.

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑IowaPotatoFarmer
add: The PMC Crash on Solaris Ridge now spawns one PMC medic survivor and one PMC engineer survivor.
fix: The Wey-Yu goon survivors now have their unique corporate white camo M41A MK2 back.
/:cl:

@toolmind toolmind requested a review from morrowwolf as a code owner July 1, 2023 07:08
@github-actions
Copy link
Contributor

github-actions bot commented Jul 1, 2023

You currently have a negative Fix/Feature pull request delta of -8. Maintainers may close this PR at will. Fixing issues or improving the codebase will improve this score.

@github-actions github-actions bot added Mapping did you remember to save in tgm format? Feature Feature coder badge Fix Fix one bug, make ten more labels Jul 1, 2023
Copy link
Contributor

@Zonespace27 Zonespace27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code good

code/modules/gear_presets/survivors.dm Outdated Show resolved Hide resolved
code/modules/gear_presets/survivors.dm Outdated Show resolved Hide resolved
@morrowwolf morrowwolf marked this pull request as draft July 11, 2023 03:05
@toolmind toolmind marked this pull request as ready for review July 11, 2023 13:25
@github-actions
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Jul 19, 2023
@morrowwolf morrowwolf added this pull request to the merge queue Jul 19, 2023
Merged via the queue into cmss13-devs:master with commit 39cf164 Jul 19, 2023
28 checks passed
cm13-github added a commit that referenced this pull request Jul 19, 2023
@github-actions
Copy link
Contributor

Your Fix/Feature pull request is currently below zero (-10). Maintainers may close future Feature/Balance PRs. Fixing issues or helping to improve the codebase will raise this score.

github-actions bot added a commit that referenced this pull request Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature coder badge Fix Fix one bug, make ten more Mapping did you remember to save in tgm format? Stale beg a maintainer to review your PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants