Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

restores the paper assets working on webroot assets #3780

Merged
merged 3 commits into from
Jul 3, 2023
Merged

restores the paper assets working on webroot assets #3780

merged 3 commits into from
Jul 3, 2023

Conversation

harryob
Copy link
Member

@harryob harryob commented Jul 1, 2023

we don't use browse_rsc stuff in 2023 please

🆑
fix: paper images should appear once again
/:cl:

@github-actions github-actions bot added the Fix Fix one bug, make ten more label Jul 1, 2023
Drulikar
Drulikar approved these changes Jul 2, 2023
View reviewed changes
Copy link
Contributor

@Drulikar Drulikar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot properly test these changes locally (they worked before w/o these changes - only broken for CDN). But they still work locally w/o a CDN and the code looks good to me.

BeagleGaming1
BeagleGaming1 approved these changes Jul 3, 2023
View reviewed changes
Copy link
Contributor

@BeagleGaming1 BeagleGaming1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good

@BeagleGaming1 BeagleGaming1 added this pull request to the merge queue Jul 3, 2023
Merged via the queue into cmss13-devs:master with commit 194bb97 Jul 3, 2023
github-actions bot added a commit that referenced this pull request Jul 3, 2023
@github-actions
Updating GBP balances for #3780
8d2a49a
cm13-github added a commit that referenced this pull request Jul 3, 2023
@cm13-github
Automatic changelog for PR #3780 [ci skip]
75381c2
@Drulikar Drulikar mentioned this pull request Jul 4, 2023
Merged
github-merge-queue bot pushed a commit that referenced this pull request Jul 5, 2023
@Drulikar
Fix even more paper logos (#3793)
feb16cf 
# About the pull request

This PR is a followup to #3780 applying the changes to even more papers.

# Explain why it's good for the game

Fixes more broken images e.g. 

![wylogo](https://github.com/cmss13-devs/cmss13/assets/76988376/f1eec408-547b-4a5f-9eb8-d38f1bf232e0)

# Testing Photographs and Procedure
<details>
<summary>Screenshots & Videos</summary>

Put screenshots and videos here with an empty line between the
screenshots and the `<details>` tags.

</details>

# Changelog
:cl: Drathek
fix: Fixed more broken logos (primarily WY research papers)
/:cl:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Drulikar Drulikar Drulikar approved these changes

@BeagleGaming1 BeagleGaming1 BeagleGaming1 approved these changes

Assignees
No one assigned
Labels
Fix Fix one bug, make ten more
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@harryob @BeagleGaming1 @Drulikar