-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds improvisation skill #3791
Adds improvisation skill #3791
Conversation
You currently have a negative Fix/Feature pull request delta of -15. Maintainers may close this PR at will. Fixing issues or improving the codebase will improve this score. |
What were the new times compared to the old times? |
E.g. on the times, using a fork for wound closure would normally incur an extra 80% penalty so 3 seconds + 0.8*3 = 5.4 seconds. The CMO had the correct 5.4 seconds, the survivor synthetic was still at 3 seconds |
You've only added this skill to three roles and added it to two checks, which is much more limited than the scope for a skill usually is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make this a trait, i'd argue the skill tier granularity isn't needed but its a bit of a balance question
I think you could rather just give the surv doctor a surgical medkit ? . Also synthsurv is already giga OP no need to make it even better |
It only got balance approved as a skill for survivor medical roles/synthetic, so it doesn't work as a species check for synthetics because the shipside unit isn't supposed to have it unless I'm misunderstanding species. The survivor doctor having a surgical medkit is already an RNG chance thing that can happen and making it guaranteed has been denied for balance. |
For those of you who are not familiar with how synthetic-related WL changes get balance approved, we have a discussion channel regarding changes where we can get the rubber stamp done as shown https://i.imgur.com/tzB8Esm.png |
About the pull request
Adds a new skill for survivor doctor/synthetic roles, surgical improvisation. The skill removes penalty for using improvised/substitute tools and can reduce penalty for working on poor surfaces at mastery.
Explain why it's good for the game
Helps improve some of the gameplay experience of the survivor synthetic, and also adds a reason to take survivor doctor instead of researcher, since without this the researcher is simply better. Also, FORECON support tech gets the skill because it is soulful that a recon marine, who is expected to be more motivated/skilled, can do IB repair a little faster in the middle of nowhere.
Testing Photographs and Procedure
Tested on a private lobby to make sure it runs without breaking things and works as intended. Tested by spawning a survivor synthetic and a CMO, and having them do ribcage opening/closing/sawing on an OR table and rollerbed, and comparing times vs the expected times in code.
Changelog
🆑
add: New skill, surgical improvisation
/:cl: