Emote panel for WJs #3792
Merged
Emote panel for WJs #3792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Sprites
Zonespace27
added
Testmerge Candidate
|
mfw i realize i made a branch off of the main repo |
it's the maintainer way |
harryob
reviewed
Jul 4, 2023
harryob
approved these changes
Jul 4, 2023
3 tasks
cm13-github
added a commit
that referenced
this pull request
Jul 8, 2023
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 10, 2023
# About the pull request Turns out #3792 made a second Joe species and overwrote it, oops <!-- Remove this text and explain what the purpose of your PR is. Mention if you have tested your changes. If you changed a map, make sure you used the mapmerge tool. If this is an Issue Correction, you can type "Fixes Issue #169420" to link the PR to the corresponding Issue number #169420. Remember: something that is self-evident to you might not be to others. Explain your rationale fully, even if you feel it goes without saying. --> # Explain why it's good for the game bug bad # Changelog :cl: fix: Fixes the Working Joe species /:cl:
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 25, 2023
# About the pull request Adds a panel I shamelessly ripped from #3792 for Yautja emotes. <!-- Remove this text and explain what the purpose of your PR is. Mention if you have tested your changes. If you changed a map, make sure you used the mapmerge tool. If this is an Issue Correction, you can type "Fixes Issue #169420" to link the PR to the corresponding Issue number #169420. Remember: something that is self-evident to you might not be to others. Explain your rationale fully, even if you feel it goes without saying. --> # Explain why it's good for the game Easy management of emotes is nice! # Testing Photographs and Procedure <details> <summary>Screenshots & Videos</summary> Put screenshots and videos here with an empty line between the screenshots and the `<details>` tags. </details> # Changelog :cl: ui: Adds a UI panel for Yautja emotes, all credit to Zonespace. /:cl: --------- Co-authored-by: Zonespace <[email protected]> Co-authored-by: harryob <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Adds an emote panel for WJs.
In addition, categorizes WJ emotes for ease of viewing in the panel, and unit tests all emotes to ensure they have a category.
Explain why it's good for the game
As joe, I have so many cool voicelines! It's a shame I can't remember the very-uber-specific emote code to say them, which this fixes.
Testing Photographs and Procedure
Screenshots & Videos
See section 1
Changelog
🆑
add: Working Joes now have an emote panel to use voice lines, accessible as an action button.
/:cl: