Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes dead queen footsteps. #3815

Merged
merged 2 commits into from
Jul 6, 2023

Conversation

realforest2001
Copy link
Member

@realforest2001 realforest2001 commented Jul 5, 2023

About the pull request

The corpse of the Queen should not be walking. Fixes #3797

Explain why it's good for the game

Bugs bad.

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
fix: Fixes Queen making footstep sounds while dead and being dragged.
/:cl:

@github-actions github-actions bot added the Fix Fix one bug, make ten more label Jul 5, 2023
@BeagleGaming1 BeagleGaming1 removed their request for review July 5, 2023 19:13
@Ben10083
Copy link
Contributor

Ben10083 commented Jul 5, 2023

Fixes #3797

@@ -31,7 +31,7 @@
return

var/mob/living/LM = parent
if(LM.buckled || LM.throwing || LM.is_ventcrawling)
if(LM.buckled || LM.throwing || LM.is_ventcrawling || LM.stat == DEAD)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this also check for uncon?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not unless/until it's coded to use an alternate sound when dragged and lying down. I just want to stop it making a sound when she's already dead as it's confusing people.

@morrowwolf morrowwolf added this pull request to the merge queue Jul 6, 2023
Merged via the queue into cmss13-devs:master with commit f33963b Jul 6, 2023
github-actions bot added a commit that referenced this pull request Jul 6, 2023
cm13-github added a commit that referenced this pull request Jul 6, 2023
@realforest2001 realforest2001 deleted the forest/queendrag branch July 10, 2023 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Fix one bug, make ten more
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Queen corpse makes Movement Noise when Moved.
5 participants