Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Burrower burrow changes and fixes #3818

Merged
merged 1 commit into from
Jul 13, 2023

Conversation

Unknownity
Copy link
Contributor

@Unknownity Unknownity commented Jul 5, 2023

About the pull request

The PR contains mostly fixes for the Burrower that have been around, that being that other xenos could slash them while they were burrowed, that they could resist (and get rid of fire) while burrowed, that they still took shrapnel and direct flame damage while burrowed, that SG autofire and sentries were shooting at a burrowed burrower, wasting ammo in the process.

Two other notable changes are that the unburrow stun now also works on other non-friendly xenomorphs (and it works on all of them, skill issue if you manage to get stunned from that as a T3/Queen) and that burrowing and unburrowing now has sounds (a change many people were positive about when it was initially included in the Impaler PR) which may find tracking and noticing the presence of burrowers easier.

burrowing sound: https://voca.ro/1dQ0pvBMidsr
unburrowing sound: https://vocaroo.com/1zzEz3NQ2Kx5

Explain why it's good for the game

Bugfixes and a counter to one of the most annoying abilities (that people consider) in the game.

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑 Unknownity
fix: Fixed burrowed mobs being able to be targeted by sentries, mines and SG autofire.
fix: Fixed burrowed mobs being able to grab mobs on the surface.
fix: Fixed burrowed mobs being able to resist while burrowed.
fix: Fixed burrowers taking damage from direct flame and shrapnel from explosions.
fix: Fixed burrowers being able to get slashed from enemy Xenos on the surface.
fix: Fixed burrowers unburrow stun to now properly target and stun enemy Xenos.
soundadd: Added sounds for the Burrower when they are burrowing and unburrowing.
/:cl:

@github-actions
Copy link
Contributor

github-actions bot commented Jul 5, 2023

You currently have a negative Fix/Feature pull request delta of -7. Maintainers may close this PR at will. Fixing issues or improving the codebase will improve this score.

@github-actions github-actions bot added Sound Blast 5 minutes of bass boosted music to our players Fix Fix one bug, make ten more labels Jul 5, 2023
@github-actions
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Jul 13, 2023
@Zonespace27 Zonespace27 added this pull request to the merge queue Jul 13, 2023
Merged via the queue into cmss13-devs:master with commit d26452b Jul 13, 2023
30 checks passed
cm13-github added a commit that referenced this pull request Jul 13, 2023
github-actions bot added a commit that referenced this pull request Jul 13, 2023
@Unknownity Unknownity deleted the burrowerstuff branch June 16, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Fix one bug, make ten more Sound Blast 5 minutes of bass boosted music to our players Stale beg a maintainer to review your PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants