Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix launch_towards ordering for facehuggers #3826

Merged
merged 2 commits into from
Jul 7, 2023

Conversation

Drulikar
Copy link
Contributor

@Drulikar Drulikar commented Jul 6, 2023

About the pull request

This PR simply fixes the order of logic that is altering facehuggers so the launch_towards icon change occurs before launch_impact.

Explain why it's good for the game

Fixes situations like https://media.discordapp.net/attachments/1069150999517868066/1126358950707728384/gank_chamber.mp4

Testing Photographs and Procedure

Screenshots & Videos

Example of two huggers:
leap

Order of events for three huggers:
image

Changelog

🆑 Drathek
fix: Fixed facehuggers incorrectly displaying thrown state when it has landed
/:cl:

@github-actions github-actions bot added the Fix Fix one bug, make ten more label Jul 6, 2023
Copy link
Contributor

@Zonespace27 Zonespace27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of the bugs of all time

@Zonespace27 Zonespace27 added this pull request to the merge queue Jul 7, 2023
Merged via the queue into cmss13-devs:master with commit 564e60a Jul 7, 2023
cm13-github added a commit that referenced this pull request Jul 7, 2023
github-actions bot added a commit that referenced this pull request Jul 7, 2023
@Drulikar Drulikar deleted the Fix_Facehugger_Leap_Icons branch July 8, 2023 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Fix one bug, make ten more
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants