Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Working Joes can no longer eat #3828

Merged
merged 6 commits into from
Jul 7, 2023

Conversation

Ben10083
Copy link
Contributor

@Ben10083 Ben10083 commented Jul 6, 2023

About the pull request

Mechanically prevents eating and being force-fed as a Joe

Explain why it's good for the game

While not worried about the Joe itself eating the Burger, it physically does not have anything to feed the burger to (The mouth is mostly aesthetic with a speaker). As such, it makes no sense that you can feed food into a Working Joe, and should not be possible.

Changelog

🆑
del: Working Joes can no longer be fed.
code: New trait: Cannot eat. Self-explanatory.
/:cl:

@Ben10083 Ben10083 marked this pull request as ready for review July 6, 2023 15:38
@github-actions github-actions bot added the Removal snap label Jul 6, 2023
@Ben10083
Copy link
Contributor Author

Ben10083 commented Jul 6, 2023

image

Copy link
Contributor

@BeagleGaming1 BeagleGaming1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code seems good

@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Jul 7, 2023
@cm13-github cm13-github removed the Merge Conflict PR can't be merged because it touched too much code label Jul 7, 2023
@harryob harryob marked this pull request as draft July 7, 2023 12:56
@Ben10083 Ben10083 marked this pull request as ready for review July 7, 2023 15:01
@Ben10083 Ben10083 requested a review from harryob July 7, 2023 15:01
@harryob harryob added the Code Improvement Make the code longer label Jul 7, 2023
@harryob harryob added this pull request to the merge queue Jul 7, 2023
Merged via the queue into cmss13-devs:master with commit 6aae27c Jul 7, 2023
github-actions bot added a commit that referenced this pull request Jul 7, 2023
cm13-github added a commit that referenced this pull request Jul 7, 2023
@Hopekz
Copy link
Contributor

Hopekz commented Jul 7, 2023

please do not feed Seegson property

@Ben10083 Ben10083 deleted the Do_Not_Feed_the_Joes branch July 7, 2023 21:36
github-merge-queue bot pushed a commit that referenced this pull request Dec 21, 2023
# About the pull request

Removes ability for Working Joes to drink

# Explain why it's good for the game

Oversight, they were already prevented from eating (#3828), but not
drinking, same logic as why they cannot drink can be applied here.

# Testing Photographs and Procedure


![image](https://github.com/cmss13-devs/cmss13/assets/91219575/db8a6709-106b-460b-ac8c-30a8926ecb07)

</details>


# Changelog
:cl:
del:  Working Joes can no longer drink
/:cl:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Improvement Make the code longer Removal snap
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants