Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Coats to the Staff Officer vendor #3840

Merged
merged 4 commits into from
Jul 15, 2023

Conversation

theselfish
Copy link
Contributor

@theselfish theselfish commented Jul 8, 2023

About the pull request

Title.
image
I am willing to toss the Tanker Jacket, as much as I miss it.
I also added the uniform to their required gear for the sake of consistency.

Explain why it's good for the game

It gives the SO more options for clothing, as it's cold on the ship.
I've also removed the free helmet they could get, for some odd reason.

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
add: SOs may now get coats in their vendor.
/:cl:

@github-actions github-actions bot added the Feature Feature coder badge label Jul 8, 2023
@theselfish
Copy link
Contributor Author

@harryob Since no maintainer was pinged.

Copy link
Member

@morrowwolf morrowwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Undo the helmet/hat change. Feel free to give them a regular cmcap as an option.

Uniform change fine.

Only service jacket choosable. Dress shouldn't be used regularly and tanker isn't for SOs.

@morrowwolf morrowwolf marked this pull request as draft July 14, 2023 10:41
@theselfish
Copy link
Contributor Author

Undo the helmet/hat change. Feel free to give them a regular cmcap as an option.

Uniform change fine.

Only service jacket choosable. Dress shouldn't be used regularly and tanker isn't for SOs.

The /ro cap is the same as the one they spawn with.
But, doing it as I type.

@theselfish
Copy link
Contributor Author

The RO's hat is, confusingly under /req.

@theselfish theselfish marked this pull request as ready for review July 14, 2023 18:57
@theselfish
Copy link
Contributor Author

@morrowwolf Sorted.

@harryob harryob added this pull request to the merge queue Jul 15, 2023
Merged via the queue into cmss13-devs:master with commit 54acb6f Jul 15, 2023
cm13-github added a commit that referenced this pull request Jul 15, 2023
github-actions bot added a commit that referenced this pull request Jul 15, 2023
@theselfish theselfish deleted the sojacket branch July 15, 2023 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature coder badge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants