Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

B5 Hammer slowdown #3860

Merged
merged 3 commits into from
Aug 3, 2023
Merged

B5 Hammer slowdown #3860

merged 3 commits into from
Aug 3, 2023

Conversation

ghostsheet
Copy link
Contributor

@ghostsheet ghostsheet commented Jul 11, 2023

About the pull request

This makes Synth b5 breaching hammer, apply a slowdown to (marines) anyone who picks it up but doesn't have the strength to use it.

Added extra warning and effect to show that MARINE REALLY SHOULDN'T pick it up and try to use it.

Explain why it's good for the game

Synth have been complaining that marines are running off their hammer.
The visible slowdown should prevent marines from running off with it too often

Changelog

🆑 ghostsheet
add: B5 Breaching Hammer will now slow down humans who picks it up.
/:cl:

@github-actions
Copy link
Contributor

You currently have a negative Fix/Feature pull request delta of -1. Maintainers may close this PR at will. Fixing issues or improving the codebase will improve this score.

@github-actions github-actions bot added the Feature Feature coder badge label Jul 11, 2023
Copy link
Member

@harryob harryob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not the correct way to handle a slowdown, look at #3392

@harryob harryob marked this pull request as draft July 13, 2023 03:40
@ghostsheet ghostsheet marked this pull request as ready for review July 20, 2023 06:50
@morrowwolf morrowwolf marked this pull request as draft July 22, 2023 08:11
Copy link
Member

@harryob harryob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit

code/game/objects/items/weapons/twohanded.dm Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2023

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Aug 1, 2023
@ghostsheet ghostsheet marked this pull request as ready for review August 3, 2023 07:28
@harryob harryob added this pull request to the merge queue Aug 3, 2023
Merged via the queue into cmss13-devs:master with commit e7f2873 Aug 3, 2023
26 checks passed
cm13-github added a commit that referenced this pull request Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature coder badge Stale beg a maintainer to review your PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants