Removes dozens of duplicate and empty icon states from over 50 dmi files #3895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Sprites
Ultimate-Fluff
changed the title
Ultimate-Fluff
changed the title
Why is this still here?
nauticall
approved these changes
Jul 15, 2023
I understand where you were coming from. First, I was only working on removing the duplicates, but then I realized viro and chem fridges are identical. However, if I were to delete them, they would produce missing icon state errors, so I differentiated them. |
ThePiachu
added
Fix
cm13-github
added a commit
that referenced
this pull request
Jul 16, 2023
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 24, 2023
# About the pull request This PR adds additional lints for dmi files: duplicate state names and a check if the count of states exceeds 512. (My first attempt at this was to modify the missing_icons unit test, but the icon_states proc ignores duplicate states.) Let me know if you would like the items_left/righthand files balanced more or if theres anything I may have missed. We don't currently have unit testing for on_mob icons due to how many just simply don't have icons. # Explain why it's good for the game Helps prevent accidental errors in DMI files that might otherwise get overlooked, and finishes the work that was started in #3895 . # Testing Photographs and Procedure <details> <summary>Screenshots & Videos</summary>   </details> # Changelog :cl: Drathek code: Added additional lints to dmi/test.py to test for duplicate state names and excessive quantity and added another type path to the missing_icons unit_test. imageadd: Renamed and moved some icons around to comply with new testing. /:cl:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Self-explanatory. Several .dmis have been excluded from icon state purging, including some unnamed/unused turfs.
Explain why it's good for the game
Reduces bloat. Duh.
Changelog
🆑 Puckaboo2
spellcheck: Some duplicate icon states have been differentiated to prevent future missing icon state errors.
imageadd: Added new icon states for chemical and virology smartfridges.
del: Removed dozens of duplicate icon states from over 50 files to reduce bloat.
del: Removed duplicate empty icon states.
/:cl: