Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zone de commandement général - 1 - Mapping CIC Rework #3903

Closed
wants to merge 63 commits into from

Conversation

LC4492
Copy link
Contributor

@LC4492 LC4492 commented Jul 15, 2023

About the pull request

This PR is focused on updating and modifying the Bridge and any command rooms around it (Such as the XO's/CO's Quarters, Synthetic Storage, etc), with the purpose of giving the place a refreshment and, of course, an improvement on efficiency. Feel free to analyse the photos below and to tinker with the map files.

Explain why it's good for the game

Analyse the map changes and say if its an improvement or not.

Testing Photographs and Procedure

Captura de Tela (405)

Captura de Tela (406)

Captura de Tela (407)

Captura de Tela (408)

Captura de Tela (409)

image

Changelog

🆑
add: Added a little more munitions for the MK1 lockers (2 more normal mags per locker) and some extra boxes of buckshot/slugs to the MK221s lockers.
maptweak: Tweaked the Almayer's Bridge and the rooms surrounding it, such as the PO's, SO's, XO's and CO's quarters and others.
/:cl:

@github-actions github-actions bot added the Mapping did you remember to save in tgm format? label Jul 15, 2023
@Huffie56
Copy link
Contributor

if this doesn't get approved you could remove what as been rejected and cut the rest into multiple PR.
i say that because what you propose is a huge change and is spread across the almayer.
been told atomize PR.

@realforest2001 realforest2001 added the Testmerge Candidate we'll test this while you're asleep and the server has 10 players label Jul 16, 2023
@LC4492
Copy link
Contributor Author

LC4492 commented Jul 16, 2023

An 'apollo' console have been added to the CIC and I adjusted some of the required accesses for airlocks and shutters, as they proved to be incoherent in tests

@cm13-github
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@LC4492
Copy link
Contributor Author

LC4492 commented Jul 29, 2023

you should ask for help to fix you merge conflict on discord.

There's no point on fixing any conflicts if the research's PR is still stuck on testmerge, when it gets approved I will need to update the map anyway, so doing so now will only make me do it again in the future.

Research PR is merged, go ahead and deconflict for TM

Everything ready to run

@morrowwolf
Copy link
Member

image

Copy link
Member

@realforest2001 realforest2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above. Also, CIC armory button is linked to the other armouries, not CIC.

@realforest2001
Copy link
Member

image
Can get locked in here.

image
This set of doors, and the ones on the other side of CIC, have double layers of CIC blast doors.

image
image
Splitting the armouries so CIC can open is useful, but it also leaves no indication that the others are open or closed. I would suggest moving the CO's safe to replace one of these SO lockers, and have the North/South facing doors use CIC armoury, and the rest of the CIC armoury shutters use the main ship one.

@realforest2001
Copy link
Member

image
Undocumented change to armoury contents, same goes for the shotgun side.

@realforest2001
Copy link
Member

realforest2001 commented Jul 29, 2023

image
Need to document your changes more than a single line changelog. This extra layer of blast doors all over the place controlled from this bubble seems unnecessary.

image
MP lockdown on here is controlled by a button on the complete other side of CIC, which makes it relatively redundant.

Copy link
Member

@morrowwolf morrowwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Random assortment of things that need changed:
HG kit needs to be back in CIC, not the CO's personal locker in his room. (I do not care if a CO councilor said otherwise)

Ammo changes need logged (although I do not mind the change to 1:2 AP:normal split). The shotgun lockers do need more buckshot/slug containers. Probably 2 of each per locker.

SOs must be within sight of each other. The center bubble will likely need to be made smaller.

The ladders west side of CIC are used by all sorts of people and having to walk through an already crowded and tight space to get to them now is not good. People should not be encouraged to walk through CIC. This must change.

CO hypersleep should be with the general command crew, not in their room.

Jones need his bed back.

My first pass opinion is the separated overwatch consoles will make non-4 SO structures far harder and needlessly annoying (especially considering that 4 SOs is rare outside of peak hours). You must justify this change to be better than the previous design or change it so two SOs can control four consoles.

Otherwise:

Officer study is neat.
New XO room looks good.
Synth closet is tight but functional.
Command power substation looks good.
CO office looks good (other than Jones bed)

@LC4492
Copy link
Contributor Author

LC4492 commented Jul 29, 2023

image Need to document your changes more than a single line changelog. This extra layer of blast doors all over the place controlled from this bubble seems unnecessary.

image MP lockdown on here is controlled by a button on the complete other side of CIC, which makes it relatively redundant.

The Military Police lockdown is meant to be used, mainly, in shipside situations where the CIC needs to be protected, such as in a boarding-party attack. It is meant to be a delaying mechanism, so the Military Police can, as an example, lockdown the back and/or side doors and be able to keep their eyes straight to the front, without the commander needing to completely lockdown CIC and block any type of crew traffic that could ever appear. The frontal lockdown is meant for the MP or any other command staff on the watch in the post to be able to delay the invading forces while they warn the commanding team on duty about the current threat.

The rest of the observations are correct and I will see the possibilities

@LC4492
Copy link
Contributor Author

LC4492 commented Jul 29, 2023

Random assortment of things that need changed: HG kit needs to be back in CIC, not the CO's personal locker in his room. (I do not care if a CO councilor said otherwise)

Ammo changes need logged (although I do not mind the change to 1:2 AP:normal split). The shotgun lockers do need more buckshot/slug containers. Probably 2 of each per locker.

SOs must be within sight of each other. The center bubble will likely need to be made smaller.

The ladders west side of CIC are used by all sorts of people and having to walk through an already crowded and tight space to get to them now is not good. People should not be encouraged to walk through CIC. This must change.

CO hypersleep should be with the general command crew, not in their room.

Jones need his bed back.

My first pass opinion is the separated overwatch consoles will make non-4 SO structures far harder and needlessly annoying (especially considering that 4 SOs is rare outside of peak hours). You must justify this change to be better than the previous design or change it so two SOs can control four consoles.

Otherwise:

Officer study is neat. New XO room looks good. Synth closet is tight but functional. Command power substation looks good. CO office looks good (other than Jones bed)

Random assortment of things that need changed: HG kit needs to be back in CIC, not the CO's personal locker in his room. (I do not care if a CO councilor said otherwise)

Ammo changes need logged (although I do not mind the change to 1:2 AP:normal split). The shotgun lockers do need more buckshot/slug containers. Probably 2 of each per locker.

SOs must be within sight of each other. The center bubble will likely need to be made smaller.

The ladders west side of CIC are used by all sorts of people and having to walk through an already crowded and tight space to get to them now is not good. People should not be encouraged to walk through CIC. This must change.

CO hypersleep should be with the general command crew, not in their room.

Jones need his bed back.

My first pass opinion is the separated overwatch consoles will make non-4 SO structures far harder and needlessly annoying (especially considering that 4 SOs is rare outside of peak hours). You must justify this change to be better than the previous design or change it so two SOs can control four consoles.

Otherwise:

Officer study is neat. New XO room looks good. Synth closet is tight but functional. Command power substation looks good. CO office looks good (other than Jones bed)

Hm...I didn't saw any beds belonging to Jones when I started to work on the rework, I don't know what is that

@LC4492
Copy link
Contributor Author

LC4492 commented Jul 29, 2023

image

This way all four SOs can see eachother with ease, now.

@ICA-usernameisunavailable
Copy link
Contributor

Untitled
-There is an undocumented blast shutter in the synthetics closet, seems unnecessary.
-I suggest the XO's bedroom door face towards the inner CIC (western wall) rather than the unsecure hallway, considering the CO's and SO's does the same.

@LC4492
Copy link
Contributor Author

LC4492 commented Jul 29, 2023

Untitled -There is an undocumented blast shutter in the synthetics closet, seems unnecessary. -I suggest the XO's bedroom door face towards the inner CIC (western wall) rather than the unsecure hallway, considering the CO's and SO's does the same.

It seems unnecessary because is missplaced.

@nauticall
Copy link
Contributor

Sorry, but I'm not a fan, to be honest. The current iteration of the CIC is deliberately designed to give officers access to all the essential computers and tools within two to five tile's worth of walking from each other. With the current CIC, you can man multiple overwatch consoles at the same time, and the CO/XO only has to walk a short bit to make an announcement towards the computer.

This layout looks pretty, but practically speaking it drastically increases travel time of officers to get from A. between overwatch consoles and B. to the operations (announcement) computers. Command's job is communication and intelligence, and extra seconds spent commuting from computer to computer can spell the difference between victory and defeat as they experience delays in gathering information. Not to mention lowpop too, where having a single XO running CIC is a regular occurrence. They can manage just fine with the existing CIC, but will have to run a marathon with this layout. Charlie asks for a critical SL change while Delta SL requests an OB -- with the current layout an officer can do both simultaneously, but with this the XO will have to run back and forth to get things done.

Overall, I get the effort you've put into making this and it looks nice. But it just isn't practical for gameplay purposes and myself as well as a few other community members have stated their dislike of the layout. The CIC is fine as it it is right now.

@nauticall nauticall added the Do Not Merge If you merge this PR, I will annihilate you label Jul 29, 2023
@LC4492
Copy link
Contributor Author

LC4492 commented Jul 29, 2023

Sorry, but I'm not a fan, to be honest. The current iteration of the CIC is deliberately designed to give officers access to all the essential computers and tools within two to five tile's worth of walking from each other. With the current CIC, you can man multiple overwatch consoles at the same time, and the CO/XO only has to walk a short bit to make an announcement towards the computer.

This layout looks pretty, but practically speaking it drastically increases travel time of officers to get from A. between overwatch consoles and B. to the operations (announcement) computers. Command's job is communication and intelligence, and extra seconds spent commuting from computer to computer can spell the difference between victory and defeat as they experience delays in gathering information. Not to mention lowpop too, where having a single XO running CIC is a regular occurrence. They can manage just fine with the existing CIC, but will have to run a marathon with this layout. Charlie asks for a critical SL change while Delta SL requests an OB -- with the current layout an officer can do both simultaneously, but with this the XO will have to run back and forth to get things done.

Overall, I get the effort you've put into making this and it looks nice. But it just isn't practical for gameplay purposes and myself as well as a few other community members have stated their dislike of the layout. The CIC is fine as it it is right now.

Making it a nightmare segment would make it viable? It could be set to only be used on higher pops, such as 150 to 160 players

@LC4492
Copy link
Contributor Author

LC4492 commented Jul 29, 2023

I may be able to easily make two versions, one which is fitted with a scheme in a smaller fashion, for small pop rounds, and this one, which is bigger and can certainly work better on bigger pops.

@Huffie56
Copy link
Contributor

i am suggesting you separate your change into multiple PR's and use this PR as resource to use to make them.
the first one to make could be the change you made on the older officer office south of the pods...
image
nobody use those...
the second one could be CO quarter but if i was you i would ask to the CO whitelist players on what could be improve...

@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Aug 3, 2023
@github-actions
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Aug 13, 2023
@github-actions github-actions bot closed this Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Do Not Merge If you merge this PR, I will annihilate you Mapping did you remember to save in tgm format? Merge Conflict PR can't be merged because it touched too much code Stale beg a maintainer to review your PR Testmerge Candidate we'll test this while you're asleep and the server has 10 players
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants