Ports TGMC autofire #3909
Merged
Ports TGMC autofire #3909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cm13-github
added
the
Merge Conflict
cm13-github
removed
the
Merge Conflict
mullenpaul
reviewed
Jul 16, 2023
mullenpaul
reviewed
Jul 16, 2023
|
Whilst it would be neat to refactor firemodes into datums - I think it could complicate the code at this point. I would generally think that we should port the code over -as is- and then make improvements on it |
Zonespace27
added
the
Testmerge Candidate
fira
reviewed
Jul 17, 2023
Nanu308
added
the
Balance
Nanu308
reviewed
Jul 23, 2023
3 tasks
harryob
requested changes
Jul 24, 2023
3 tasks
harryob
approved these changes
Jul 24, 2023
cm13-github
added a commit
that referenced
this pull request
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Tears out CM's autofire system and replaces it with TGMC's.
Shouldn't affect anything on the front-end beyond an unreported bug, and maybe making lag a bit better.
tgstation/TerraGov-Marine-Corps#6064
tgstation/TerraGov-Marine-Corps#6164
Regexes used:
Fire delay
F:
([^/])fire_delay = ([A-Z_1-90. *+-]+)R:
$1set_fire_delay($2)Burst delay
F:
([^/])burst_delay = ([A-Z_1-90. *+-]+)R:
$1set_burst_delay($2)Burst amount
F:
([^/])burst_amount = ([A-Z_1-90. *+-]+)R:
$1set_burst_amount($2)Explain why it's good for the game
Autofire becoming less terrible is one of the things necessary to be able to add autofire to more guns.
Changelog
🆑 BraveMole, Zonespace
fix: Smartgunners can no longer shoot their smartgun while aghosted
balance: The Uzi and Mac-15 now have full-auto
/:cl: