Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synthflesh and Predalien Butchering of Synthetics Revamp #3910

Merged
merged 11 commits into from
Jul 25, 2023

Conversation

Ben10083
Copy link
Contributor

@Ben10083 Ben10083 commented Jul 16, 2023

About the pull request

Predalien butcher now makes synthetic meat from synths, and cannot make meat from Working joes (still get gibbed though). At request of the council, new meat subtype under synthflesh for when this occurs. Meat is slightly toxic.

Explain why it's good for the game

Working Joes turning into edible meat has terrifying undertones and shouldn't happen, synthetics now make special meat when butchered by predalien

Changelog

🆑
fix: Working Joes no longer spawn meat when butchered by Abominations
fix: Synthetics now are butchered into synthflesh when butchered by Abominations
add: special meat subtype 'synthflesh' if Synthetics get butchered. Uses same recipes as synthmeat
imageadd: synthflesh sprite
/:cl:

@github-actions github-actions bot added the Fix Fix one bug, make ten more label Jul 16, 2023
@Ben10083
Copy link
Contributor Author

The Forbidden meat
image

@Ben10083 Ben10083 changed the title You can no longer butcher Synths as Predalien Synthflesh and Predalien Butchering of Synthetics Revamp Jul 17, 2023
Copy link
Member

@harryob harryob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doing type checks in a loop isn't ideal. ideally these vars would be stored on the species tbh. you could do that. you should (but don't have to)

@harryob harryob marked this pull request as draft July 22, 2023 12:54
@Ben10083 Ben10083 marked this pull request as ready for review July 22, 2023 15:06
@Ben10083 Ben10083 requested a review from harryob July 22, 2023 15:06
@harryob harryob enabled auto-merge July 24, 2023 22:23
@harryob harryob added this pull request to the merge queue Jul 24, 2023
Merged via the queue into cmss13-devs:master with commit 2dec797 Jul 25, 2023
25 checks passed
cm13-github added a commit that referenced this pull request Jul 25, 2023
github-actions bot added a commit that referenced this pull request Jul 25, 2023
@Ben10083 Ben10083 deleted the Joe_Meat branch July 25, 2023 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Fix one bug, make ten more
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants