Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yautja surgery target zone change #3911

Merged
merged 2 commits into from
Jul 20, 2023

Conversation

Awantje
Copy link
Contributor

@Awantje Awantje commented Jul 17, 2023

About the pull request

I had a bit of an issue with the medicomp. My head as yautja was damaged and I targeted my head.
There is no indication at all you must target the chest. Now you can target any zone.
I ran to a few issues/glitches on the way.

  1. The yautja mask blocks surgery.
  2. Parallel surgery would become possible.

The mask had a flag (BLOCKSHARPOBJ) that is only used once:
Here exactly
That proc is only called specificly once:
Over here
To litterly block surgery. There is nothing else the flag does.

By not caring about what is targeted you could start multiple surgeries in parallel.
And I edited the initial surgery check to check for this.
It also tells you where it is ongoing should you have changed targets or not know for some reason.

I have tested my changes. With all targetable regions. You cannot do it on the limb you are holding the items in and thats fine.

Explain why it's good for the game

Mostly because it gives no feedback on what you do wrong. And it's a trivial thing to overlook. It also makes sense to target the head if you have head damage on instinct.

Testing Photographs and Procedure

Changelog

🆑
code: Medicomp surgery tools no longer care about what zone you target.
/:cl:

Changes it so that you do not have to target the chest to start medicomp surgery as a yautja. And the flag is needed for surgery in the head location.
Prevents paralel surgery for yautja
@github-actions github-actions bot added the Code Improvement Make the code longer label Jul 17, 2023
@harryob harryob added this pull request to the merge queue Jul 20, 2023
Merged via the queue into cmss13-devs:master with commit da0c1fd Jul 20, 2023
github-actions bot added a commit that referenced this pull request Jul 20, 2023
cm13-github added a commit that referenced this pull request Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Improvement Make the code longer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants