Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update squad vendors reduce numbers of items for squad and increase it for requisition. #3912

Closed

Conversation

Huffie56
Copy link
Contributor

@Huffie56 Huffie56 commented Jul 17, 2023

About the pull request

this is an early draft just putting it there so people know i am working on vendors.
The main idea of this PR is to make all the vendors up to date:
1-assign a role to every vendors(weapons,ammo,clothes etc...
2-Update name and description.
3-More to come
One of the secondary idea is to add the ability for every marine roles to choose their primary weapon in their vendors.
second secondary idea is to reduce the number of item in Squad prep and move part of what's remove into requisition.
idea is for marines to have enough to last a 5h round.

Explain why it's good for the game

Make everything more coherent
First attempt to increase scarcity in squad prep(don't worry requisition will have enough stock to compensate)

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
qol: remove M56 smartgun magazine from ammo squad vendors and put it directly into the SG belts.
balance: Divided by five the number of weapons and attachments in squads vendors and increase it in requisition.
balance: Divided by two the number of ammo in squads vendors and multiply it by four in requisition.
code: add the ability for every squad marine role to choose one primary weapon.
/:cl:

Julien and others added 2 commits July 17, 2023 11:30
belt
divide by two the standart ammo in surplus
arm vendors and multiply by 4 thos in req.
divide by five the number of  weapons and
attachements
but  multiply by two their number in req
remove the M2C mag in prep vendor
since the gun can only be found in req.
@github-actions github-actions bot added Quality of Life Make the game harder to play Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Code Improvement Make the code longer labels Jul 17, 2023
@Huffie56
Copy link
Contributor Author

Huffie56 commented Jul 19, 2023

that's some time since i didn't made a code PR so let's see how bad you found it...
for the devs tell me if some of it need to be remove or if it need to be atomized..

@Huffie56 Huffie56 marked this pull request as ready for review July 19, 2023 12:01
@Huffie56
Copy link
Contributor Author

Huffie56 commented Jul 19, 2023

waiting that the morrow PR get merge i guess....
will adapt mine after...
#3934

@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Jul 20, 2023
@cm13-github cm13-github removed the Merge Conflict PR can't be merged because it touched too much code label Jul 20, 2023
@Huffie56 Huffie56 marked this pull request as draft July 20, 2023 11:12
@Huffie56
Copy link
Contributor Author

probably going to have to cut it down to pieces and make smaller PR's...

@github-actions
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Jul 31, 2023
@Huffie56
Copy link
Contributor Author

closing it because i am just going to use it to make PR out of it....

@Huffie56 Huffie56 closed this Jul 31, 2023
@Huffie56 Huffie56 deleted the clean_squa_vendors_inventory branch August 15, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Code Improvement Make the code longer Quality of Life Make the game harder to play Stale beg a maintainer to review your PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants