Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a new Gin Bottle design, visually different than that of the Vodka. #3914

Merged
merged 3 commits into from
Jul 19, 2023

Conversation

Kaboomkat
Copy link
Contributor

@Kaboomkat Kaboomkat commented Jul 17, 2023

About the pull request

This PR adds a new Gin Bottle design, as the one currently in game is visually identical to the Vodka Bottle design, it is inspired in the Tanqueray London Dry Gin, and reflects the items' description, which states: "A bottle of high-quality gin, produced in the New London Space Station." Sprites made by me.

Explain why it's good for the game

These Changes would benefit the game in a visual manner, as the gin bottle would be easier to identify from a vodka bottle.

Testing Photographs and Procedure

https://i.imgur.com/ovpUNab.png

https://i.imgur.com/437rSGS.png

Screenshots & Videos

The old Vodka and Gin bottles side by side, and then, the new Gin bottle

Changelog

🆑 Kaboomcat
imageadd: Updated the gin bottle sprite
/:cl:

@Kaboomkat Kaboomkat changed the title Adds a new Gin Bottle design, visually diffrent than that of the Vodka. Adds a new Gin Bottle design, visually different than that of the Vodka. Jul 17, 2023
@github-actions github-actions bot added the Sprites Remove the soul from the game. label Jul 17, 2023
@thwompa
Copy link
Contributor

thwompa commented Jul 17, 2023

awesome first pr

Copy link
Contributor

@nauticall nauticall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

here's a list of what I think you should change to match the artstyle more:

WHOLE SPRITE: Design's great! But you need to work on your coloring a bit. CM's artstyle uses limited, desaturated colors and has a specific style for how to use them.

🔴 RED: Make shading consistent. I'd recommend looking at existing drink bottles for reference on the shading guide for them. Key points: Use a limited amount of colors and keep it symmetrical.
image

🟡 YELLOW: Try to avoid using shades that blend together too well with each other. Try to 'checkerboard' them so that shades of the same color will only touch diagonally on corners. Again, look at preexisting drink bottles to see what I mean.

🔵 BLUE: Try to avoid using pure grays and whites, as CM's artstyle really doesn't like those. I'd recommend hue-shifting them to a more yellowish-white (like a cream color).

🟢 GREEN: Try to keep colors symmetrical and avoid having rogue dots like this.

@Kaboomkat
Copy link
Contributor Author

Changed the design to this Frans F. Feiffner one:
Tanqueray TRUE new by fran

@Kaboomkat Kaboomkat requested a review from nauticall July 18, 2023 17:31
Copy link
Contributor

@nauticall nauticall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

muuuuch better!

@nauticall nauticall added the Sprites Approved confirmed no stray pixels label Jul 19, 2023
@Drulikar Drulikar added the Good First PR From small acorns label Jul 19, 2023
@Drulikar Drulikar added this pull request to the merge queue Jul 19, 2023
Merged via the queue into cmss13-devs:master with commit 6f0ecb3 Jul 19, 2023
github-actions bot added a commit that referenced this pull request Jul 19, 2023
cm13-github added a commit that referenced this pull request Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First PR From small acorns Sprites Approved confirmed no stray pixels Sprites Remove the soul from the game.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants