Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Xenos scuttle + Allied Xenos Using Doors #3915

Merged
merged 2 commits into from
Jul 19, 2023

Conversation

TeDGamer
Copy link
Contributor

@TeDGamer TeDGamer commented Jul 17, 2023

About the pull request

Reviving #3128 since I finally have time to work on these again

Fixing scuttle code and incidentally, allied xenos opening doors

Explain why it's good for the game

Playable facehuggers were intended to scuttle but the code wasn't updated to handle them.

This refactors the code so that all small xenos ( larva, facehugger, future small castes?) can scuttle properly and removes duplicate code from both the updated facehugger code and old larva scuttle code that wasn't up to date in code style ( one letter var names for example )

Incidentally, I fix allied xenos using hive's doors. So allied xenos can toggle hive doors and allied small xenos can scuttle hive's doors

Changelog

🆑
fix: Xenos allied to the hive can now open hive's doors
fix: Huggers can now scuttle doors
code: Combined hugger + larva code to allow for any small castes to scuttle
/:cl:

@github-actions github-actions bot added Fix Fix one bug, make ten more Refactor Make the code harder to read labels Jul 17, 2023
@TeDGamer
Copy link
Contributor Author

Whoops, that should be a code tag, not a refactor tag. Please someone replace the refactor with code.

@Drulikar Drulikar added Code Improvement Make the code longer and removed Refactor Make the code harder to read labels Jul 17, 2023
@harryob harryob added this pull request to the merge queue Jul 19, 2023
Merged via the queue into cmss13-devs:master with commit b0f6dcf Jul 19, 2023
github-actions bot added a commit that referenced this pull request Jul 19, 2023
cm13-github added a commit that referenced this pull request Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Improvement Make the code longer Fix Fix one bug, make ten more
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants