[Fix] Xenos scuttle + Allied Xenos Using Doors #3915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Fix
|
Whoops, that should be a code tag, not a refactor tag. Please someone replace the refactor with code. |
Drulikar
added
Code Improvement
harryob
approved these changes
Jul 18, 2023
cm13-github
added a commit
that referenced
this pull request
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
Reviving #3128 since I finally have time to work on these again
Fixing scuttle code and incidentally, allied xenos opening doors
Explain why it's good for the game
Playable facehuggers were intended to scuttle but the code wasn't updated to handle them.
This refactors the code so that all small xenos ( larva, facehugger, future small castes?) can scuttle properly and removes duplicate code from both the updated facehugger code and old larva scuttle code that wasn't up to date in code style ( one letter var names for example )
Incidentally, I fix allied xenos using hive's doors. So allied xenos can toggle hive doors and allied small xenos can scuttle hive's doors
Changelog
🆑
fix: Xenos allied to the hive can now open hive's doors
fix: Huggers can now scuttle doors
code: Combined hugger + larva code to allow for any small castes to scuttle
/:cl: