Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Experimental] Modifies INTERRUPT_NO_NEEDHAND flag #3935

Merged
merged 1 commit into from
Jul 20, 2023

Conversation

morrowwolf
Copy link
Member

@morrowwolf morrowwolf commented Jul 19, 2023

About the pull request

This PR changes INTERRUPT_NO_NEEDHAND in the following way:
If the user needed an item they must have keep that item in one hand to the end of the do_after()

This should prevent dropping/putting away items while doing something.

This will affect the following interactions (at least):
Pilling someone
Splinting someone
Defib'ing someone
And about 100 more do_after()'s

We'll see if this feels better or worse. No matter what happens we will not be going back to dropping/putting away items and still using them.

Probably will have to rename the interrupt for clarity. Happy to take suggestions.

Explain why it's good for the game

Splints were recently changed to be INTERRUPT_NEEDHAND and it slows medics down considerably and completely takes the individual out of the flow state. The enjoyment of playing medic is trying to do things as fast as possible. This allows things to be fast while also not silly (put away or dropped and still continuing). You have two hands, you can do two things at once.

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑 Morrow
balance: Modifies INTERRUPT_NO_NEEDHAND flag to require you hold the item at least in one hand.
balance: Changes splint back to using INTERRUPT_NO_NEEDHAND
/:cl:

@github-actions github-actions bot added the Balance You need to be a professional veteran game maintainer to comprehend what is being done here. label Jul 19, 2023
@harryob harryob added this pull request to the merge queue Jul 20, 2023
Merged via the queue into cmss13-devs:master with commit d92c79e Jul 20, 2023
cm13-github added a commit that referenced this pull request Jul 20, 2023
github-actions bot added a commit that referenced this pull request Jul 20, 2023
@morrowwolf morrowwolf deleted the no_needhand-changes branch August 17, 2023 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance You need to be a professional veteran game maintainer to comprehend what is being done here.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants