Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More portable cades tweaks and buffs #3967

Merged
merged 13 commits into from
Jul 30, 2023
Merged

Conversation

ihatethisengine
Copy link
Contributor

@ihatethisengine ihatethisengine commented Jul 22, 2023

About the pull request

Despite making a lot of tweaks and changes to portable cades I barely touched them in the game until recently. Now I have more experience and can tweak it again.

  1. You can now stack damaged cades and stack stores health of each cade. You can repair stacked cades but it will take longer time.

  2. Miniengi pamphlet allows faster repairs but only when cade is folded.

  3. You can quickly collapse portable cades with crowbar if you have at least miniengi skills.

  4. You no longer need to have folded portable cade in hand in order to repair it, but if you do, you can move while repairing.

Explain why it's good for the game

  1. It's extremely annoying to repair each individual cade in order to stack them just because it got hit by a stray bullet once. Now you can just ignore damage and keep going.

  2. Yeah it took 10 second for PFC to repair each single cade. Really long. Now it's 5 seconds, but only when folded and if you have miniengi skills. Makes miniengi pamphlet a bit more relevant.

  3. It was intended, but turned out it was a bit inconvenient. It was faster to collapse by hand because you didn't need to deal with tools. Now it requires just a crowbar and slightly faster. Also requires miniengi skill to use crowbar.

  4. First was just a bit annoying, second allows more mobility which is the point of portable barricades.

Testing Photographs and Procedure

Screenshots & Videos

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑 ihatethisengine
balance: You can now stack damaged cades and stack stores health of each cade. You can repair stacked cades but it will take longer time.
balance: you can repair stacked portable cades but it will take longer time depending on how many cades in stack.
balance: miniengi skill makes repairs of folded portable cades faster (10 seconds to 5 seconds, same as engineer).
balance: with engineering skill at least of miniengi you can collapse deployed portable barricade with a crowbar (wrench is no longer required, slightly faster (2 sec to 1.5 sec)).
balance: you no longer need to have folded portable cade in hand in order to repair it.
balance: if you have folded portable cade in hand, you can move while repairing it.
/:cl:

@github-actions github-actions bot added the Balance You need to be a professional veteran game maintainer to comprehend what is being done here. label Jul 22, 2023
Copy link
Member

@harryob harryob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code is fine

@morrowwolf
Copy link
Member

You can now stack scratched portable cades if their HP > 75%. But this will reduce the health of all barricades in the stack to the level of the most damaged. You can repair stacked cades but it will take longer time.

This smells like a coder block rather than a real thought out feature. Make the stack store the damage values of the portacades or don't do this at all.

Miniengi pamphlet allows faster repairs but only when cade is folded.

Why just when folded?

@morrowwolf morrowwolf marked this pull request as draft July 27, 2023 11:25
@ihatethisengine
Copy link
Contributor Author

ihatethisengine commented Jul 27, 2023

Why just when folded?

Don't want to affect actual combat balance, because miniengi pamphlet doesn't allow faster repairs of regular cades. But if you think it's fine then sure, I'll let miniengi to repair unfolded portable cades faster.

@morrowwolf
Copy link
Member

Why just when folded?

Don't want to affect actual combat balance, because miniengi pamphlet doesn't allow faster repairs of regular cades. But if you think it's fine then sure, I'll let miniengi to repair unfolded portable cades faster.

Honestly was just curious. This is good reasoning I say keep it.

@ihatethisengine
Copy link
Contributor Author

This smells like a coder block rather than a real thought out feature. Make the stack store the damage values of the portacades or don't do this at all.

Quite a task it was, but I think I got it working.

ihatethisengine added 2 commits July 27, 2023 16:37
@ihatethisengine ihatethisengine marked this pull request as ready for review July 27, 2023 13:45
@morrowwolf morrowwolf added the Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. label Jul 29, 2023
@harryob harryob marked this pull request as draft July 29, 2023 07:24
@ihatethisengine ihatethisengine marked this pull request as ready for review July 30, 2023 01:06
@harryob harryob added this pull request to the merge queue Jul 30, 2023
Merged via the queue into cmss13-devs:master with commit f5784da Jul 30, 2023
26 checks passed
cm13-github added a commit that referenced this pull request Jul 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance Approved This PR has had its balance and gameplay-affecting aspects approved. Cry to the Head-maint about it. Balance You need to be a professional veteran game maintainer to comprehend what is being done here.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants