Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update brig area to make more sense. #3973

Closed
wants to merge 7 commits into from

Conversation

Huffie56
Copy link
Contributor

@Huffie56 Huffie56 commented Jul 23, 2023

About the pull request

1-Merge the two hypersleep room into one for brig.
2-Put evidence room where interrogation room and move interrogation room just north of processing room in brig.
3-cleaning up the area to make them aesthetic around the changes...

Explain why it's good for the game

1-we shouldn't have two hypersleep room for a department with 8 people maximum...
2-it make more sense to have interrogation room near processing room so that MP know it's here ...

Testing Photographs and Procedure

Screenshots & Videos

image

Put screenshots and videos here with an empty line between the screenshots and the <details> tags.

Changelog

🆑
maptweak: Merge the two hypersleep room into one for brig.
maptweak: Put evidence room where interrogation room and move interrogation room just north of processing room in brig.
/:cl:

@github-actions github-actions bot added the Mapping did you remember to save in tgm format? label Jul 23, 2023
@Huffie56
Copy link
Contributor Author

if you need me to provide more reason to why i did this or that i am all there just tag me here or on discord
and if you aren't reviewing just use the discord project chanel:
https://discord.com/channels/150315577943130112/1101181191211724890/threads/1132573735258435674

@Huffie56 Huffie56 marked this pull request as ready for review July 23, 2023 18:42
Copy link
Member

@realforest2001 realforest2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Firstly, don't remove the windows in maintenance. They're not "bugs" they're deliberately there to allow looking out into space. The same reason there are windows in the access corridors north and south of CIC.

Second, can you change req_access & req_one_access_txt on the north door here
image
to match these, as this will allow senior command staff to open it as they can access the north half of Brig for this reason.
image

@realforest2001 realforest2001 marked this pull request as draft July 24, 2023 18:21
@Huffie56 Huffie56 marked this pull request as ready for review July 24, 2023 19:15
@Huffie56
Copy link
Contributor Author

i added back the window in maintenance...
i change the variable to match what you show on your message above.

@Huffie56 Huffie56 requested a review from Nanu308 July 25, 2023 12:05
@Huffie56 Huffie56 changed the title Update brig area to make more sense and fixing a bug. Update brig area to make more sense. Jul 25, 2023
@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Jul 28, 2023
@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@Huffie56 Huffie56 marked this pull request as draft July 28, 2023 22:15
@Huffie56
Copy link
Contributor Author

going to wait for forest PR to be merge before i fix the conflict.

@github-actions
Copy link
Contributor

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale beg a maintainer to review your PR label Aug 15, 2023
@cm13-github cm13-github removed the Merge Conflict PR can't be merged because it touched too much code label Aug 21, 2023
@cm13-github
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@Huffie56 Huffie56 marked this pull request as ready for review August 21, 2023 09:47
@github-actions github-actions bot removed the Stale beg a maintainer to review your PR label Aug 22, 2023
@morrowwolf
Copy link
Member

Not super feeling this one sorry brother. The evidence lockers are close to processing because usually it's for gear taken by MPs and not returned so having it close is nice. Interrogation room moving closer to the most active part of the brig just confuses the situation unnecessarily.

Thanks for your work but I'll be passing on this.

@morrowwolf morrowwolf closed this Aug 22, 2023
@Huffie56 Huffie56 deleted the up-to-date-brig branch August 22, 2023 14:19
@Huffie56
Copy link
Contributor Author

no worries.
good thing i didn't sink more hour in renovated brig.
(was thinking about renovate the infirmary, the armory and adding an holding cell)
was testing the water... i understand the argument for evidence locker being closer.
the part about investigation room being at processing being confusing not so much....
my big guess is that you aren't interested in any change to brig.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mapping did you remember to save in tgm format?
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants