Fix Some Preferences Not Saving #3975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nitization when loaded. Now 24 bit.
… indicating you can hurt yourself.
harryob
approved these changes
Jul 24, 2023
cm13-github
added a commit
that referenced
this pull request
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the pull request
This PR increases the size of some settings (namely toggle_prefs) from 16 bits to 24 bits so preferences like TOGGLE_LATE_JOIN_CURRENT_SLOT and TOGGLE_ABILITY_DEACTIVATION_OFF will now actually stick.
Explain why it's good for the game
Fixes at least two preferences not saving/loading correctly.
Testing Photographs and Procedure
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>tags.Changelog
🆑 Drathek
fix: Fixed ability deactivation and late join current slot toggles not persisting.
fix: Toggle the Ability to Hurt Yourself now says On when you can hurt yourself.
/:cl: