Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ares Nuke Request #3988

Merged
merged 57 commits into from
Jul 25, 2023
Merged

Ares Nuke Request #3988

merged 57 commits into from
Jul 25, 2023

Conversation

Ben10083
Copy link
Contributor

@Ben10083 Ben10083 commented Jul 25, 2023 •
edited by github-actions bot
Loading

About the pull request

Implements ARES Emergency Procedure 'Request Nuke', which allows someone to petition High Command (Admins) for a nuke

Explain why it's good for the game

This is already implemented in the framework for Project ARES, this just adds the feature. Should be fine as admins will need to authorize it. If people want a different rank for such nuke requests I can have it done.

Changelog

🆑
add: You can now petition High Command via ARES for a nuclear device, bypassing techweb (If you can convince them, that is.)
admin: Implemented Admin side of ARES Nuke request to allow for granting of different nuke types, or denying the request.
/:cl:

realforest2001 and others added 30 commits June 28, 2023 19:05
@realforest2001
Code quality
02b9ae8
@realforest2001
Started work on reports
14276e8
@realforest2001
ID and ARES size
455ec58
@realforest2001
12.8.3
271d2c5 
Makes maintenance tickets functional.
Adds two new maintenance reports.
Todo: Make it so WJs can view this from anywhere.
Todo: Access ticket functionality.
@realforest2001
Merge branch 'master' into project/apollo_controller
263e889
@realforest2001
ARES punctuation & Fixes
506254e 
x


x


access tweak


x
@realforest2001
ui icons
0713611
@realforest2001
Apollo Follow
708a9df 
x


x
@realforest2001
red
c4269d6 
Auto stash before cherry pick of "red"
@Ben10083
Proc creation
689faea
@Ben10083
Implement proc to various admin functions
9812da5
@Ben10083
Add ares log proc
23dadb8
@Ben10083
Implement proc
21a1f4e
@Ben10083
Log bioscan only if ares can log
4e533a9
@Ben10083
Beagle Request: Allow messages to send even without working processor…
9d35a04 
… if wanted
@Ben10083
Nit Picks
185c8a6
@Ben10083
Bioscan Failure Announcement
9e9ef12
@Ben10083
Rename of bioscan proc
495c132
@Ben10083
Log failure into Bioscan Logs
e6823fa
@Ben10083
oops need to move variable
d5e7054
@Ben10083
forced exception
01a2f5d
@Ben10083
istype link checks for procs
eaa1e7f
@Ben10083
Edit to Bioscan logging proc
65328b6
@Ben10083
Adjustment: bioscan will log if interface down
643a85f
@Ben10083
Change of format for failure message
9bb1e38
@Ben10083
forgot to check if interface subsystem also goes down for bioscan fai…
2bce20f 
…lure
@Ben10083
Proper procs used
895867e
@Ben10083
Inform admins if bioscan occurred but not announced/logged
c2f8cbd
@Ben10083
Remove admin msgs (made a mistake, fixing)
a67c63d
@Ben10083
Restore old msg
a2769a2
@Ben10083 Ben10083 reopened this Jul 25, 2023
@github-actions github-actions bot added UI deletes nanoui/html Feature Feature coder badge Admin Make things harder for admins labels Jul 25, 2023
@realforest2001 realforest2001 added this to the Project ARES milestone Jul 25, 2023
@Ben10083
Copy link
Contributor Author

Ignore the thousands of commits, it is now Ready™

@Ben10083 Ben10083 marked this pull request as ready for review July 25, 2023 02:32
harryob
harryob requested changes Jul 25, 2023
View reviewed changes
code/modules/admin/topic/topic.dm Show resolved Hide resolved
code/modules/admin/topic/topic.dm Show resolved Hide resolved
@harryob harryob marked this pull request as draft July 25, 2023 15:50
@Ben10083 Ben10083 requested a review from harryob July 25, 2023 17:30
@Ben10083 Ben10083 marked this pull request as ready for review July 25, 2023 17:30
@harryob harryob added this pull request to the merge queue Jul 25, 2023
Merged via the queue into cmss13-devs:master with commit f9e7ecc Jul 25, 2023
25 checks passed
cm13-github added a commit that referenced this pull request Jul 25, 2023
@cm13-github
Automatic changelog for PR #3988 [ci skip]
8903cf0
@Ben10083 Ben10083 deleted the ARES_Nuke branch July 25, 2023 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harryob harryob harryob approved these changes

Assignees
No one assigned
Labels
Admin Make things harder for admins Feature Feature coder badge UI deletes nanoui/html
Projects
None yet
Milestone
Project ARES
Development

Successfully merging this pull request may close these issues.
3 participants
@Ben10083 @harryob @realforest2001