Fluff Command RP Career Paths (DRAFT) #3999
Conversation
|
Added a new logistics look for that bitch Howard. Updated image to reflect |
| @@ -100,6 +100,7 @@ var/const/MAX_SAVE_SLOTS = 10 | |||
| var/predator_flavor_text = "" | |||
| //CO-specific preferences | |||
| var/commander_sidearm = "Mateba" | |||
| var/co_career_path = "infantry" | |||
There was a problem hiding this comment.
/// This is a code doc comment! Mind the three slashes.
var/your_var = valueThere was a problem hiding this comment.
No 3 slashes from what I see I added, but I deleted the existing ones I saw. If that makes you happy.
| new_human.equip_to_slot_or_del(new /obj/item/device/binoculars/range/designator(new_human), WEAR_L_HAND) | ||
| if(kit) | ||
| new_human.equip_to_slot_or_del(new kit(new_human), WEAR_IN_BACK) | ||
| if(new_human.client && new_human.client.prefs) |
There was a problem hiding this comment.
this switch statement is pretty gross, please handle this in some other way. For example, making subtypes of /datum/equipment_preset/uscm_ship/commander and changing the CO's equipment preset to that subtype prior to equipping anything
There was a problem hiding this comment.
Sure, suggestions on how you'd do it differently? Mainly used to HTML/CSS, not .dm
config/example/role_whitelist.txt
Outdated
| @@ -39,3 +39,4 @@ | |||
| ####################################################### | |||
|
|
|||
| #Your_name_here +Everything | |||
| Misfrag +Everything | |||
There was a problem hiding this comment.
I'm not the brightest tool in the shed
There was a problem hiding this comment.
Fixed on my end, will commit the fix in a bit.
|
Imo the white cap looks more like medical than engineering. Not sure if mislabeled The red cap is labeled medical atm |
Ooh, good catch. I just mislabeled what was what on the Github due to 3 AM code review |
|
COs should not spawn with any piece of formalwear, as our SOP specifically mentions it being intended for special occasions. While not banned from usage otherwise, we don't want to specifically spite that statement right out of the gate just by spawning in. |
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
cm13-github
added
the
Merge Conflict
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
About the pull request
So, there's been an increasing amount of COs with varied niches to their characters from my understanding. Some prominent examples are Soomis, who formerly played an Intel Major, NuSix who plays a logistics Major, and myself who does an Airwing major. I thought with these varied characters and units COs are RPing out leading, it'd be nice to add some ingame representation of the matter.
This PR seeks to represent that fact ingame by adding optional command path preferences for COs. Six options exist:
Infantry is the default option, and what I suspect will be the most used. The others have to be manually set as preference by a CO player.
Explain why it's good for the game
This PR is meant to add more flexibility and customization options to CO players, alongside that, it seeks to achieve a better representation of lore written for CO characters in game. It does that by adding these fluff career paths that COs can manually select that have corresponding outfits. No actual items or pouches are changed, only hat, uniform, gloves and boots.
Testing Photographs and Procedure
Left to Right: Infantry, Medical, Engineering, Intel, Logistics, Aviation
Left to Right: Infantry, Medical, Engineering
Left to Right: Intel, Logistics, Aviation
Left to right: Infantry, Engineering, Medical, Intel, Logistics, Aviation
Changelog
🆑 Misty
add: Adds command career paths for COs. This lets you select from six different career paths that spawn you in with different ingame outfits.
/:cl:
For now, this is a draft at Naut's suggestion for those within the CL whitelist to view and discuss upon internally.