Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gun bugfixes #4006

Merged
merged 1 commit into from
Jul 28, 2023
Merged

Gun bugfixes #4006

merged 1 commit into from
Jul 28, 2023

Conversation

ghostsheet
Copy link
Contributor

@ghostsheet ghostsheet commented Jul 26, 2023

About the pull request

Fixed Advanced mini flamers being able to switch to volatile mode (and nerfing itself, the min flamer is already volatile+ by default)

Removed the copy and paste stats of intergrated HG shotgun's stock, it should be aesthetics attachment only and was implemented poorly

Explain why it's good for the game

Bug bad, advanced mini flamer shouldn't be nerfing itself by accident

HG intergrated stock stat is just purely aesthetics, any stat change should be done to the gun itself. Similar to Smart gun barrel,
I suspect the stock was used to bypass sprite 32 pixel limit, and was just a mistake by the previous contributor in #453.

Changelog

🆑 ghostsheet
fix: Advanced mini flamer can no longer nerf itself by changing mode.
add: HG 37-12 pump shotgun's intergrated stock no longer give any stat change.
/:cl:

@github-actions github-actions bot added Fix Fix one bug, make ten more Feature Feature coder badge labels Jul 26, 2023
Copy link
Contributor

@Zonespace27 Zonespace27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the sniper and dual tube fixes, I've rolled those into another PR already

@Zonespace27 Zonespace27 marked this pull request as draft July 26, 2023 13:54
@Zonespace27 Zonespace27 added Balance You need to be a professional veteran game maintainer to comprehend what is being done here. and removed Feature Feature coder badge labels Jul 26, 2023
@ghostsheet ghostsheet marked this pull request as ready for review July 26, 2023 13:57
@harryob harryob added this pull request to the merge queue Jul 28, 2023
Merged via the queue into cmss13-devs:master with commit 43a3680 Jul 28, 2023
26 checks passed
cm13-github added a commit that referenced this pull request Jul 28, 2023
@ghostsheet ghostsheet deleted the Gun-fixes branch August 3, 2023 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance You need to be a professional veteran game maintainer to comprehend what is being done here. Fix Fix one bug, make ten more
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants